Giter Club home page Giter Club logo

Comments (5)

nicped avatar nicped commented on June 30, 2024

Hi
Thank you for the report - can you give me an example where it fails - steps to reproduce so I can verify the issue? Maybe using the configuration page of Swiffyslider.com

Would this change (changing from '>=' to '>' not do the same and in a more clean way?
if (container.scrollLeft > (container.scrollWidth - container.offsetWidth) && next && !noloop)

BR Nicolai

from swiffy-slider.

hliascto avatar hliascto commented on June 30, 2024

Hi Nicolai, actually no, I just tried your recommendation and it does not solve the problem.

To replicate the issue, please follow these steps:

  1. Using a mobile phone, navigate here: https://swiffyslider.com/examples/
  2. Go to the "Articles" example.
  3. Tap on the right arrow, as shown in the following image, to scroll through the slides until you reach the last slide. image
  4. After reaching the last slide, you will notice that nothing happens when you tap on the right arrow.

In contrast, if you perform the same action on a desktop device, clicking on the arrow of the last item will automatically take you to the beginning, which is the expected behavior by the user.

Best,
hlias

from swiffy-slider.

nicped avatar nicped commented on June 30, 2024

I cannot reproduce that on my devices - it scrolls back to start on last slide when clicking the right navigation arrow.
I can see from your screenshot that it is not a mobile device as that example would have the arrows on top of the slides on mobile.

What device and browser are you using?

from swiffy-slider.

hliascto avatar hliascto commented on June 30, 2024

Yes that was actually a screenshot from a desktop browser. My device is a Xiaomi Redmi Note 11 Pro (it uses Android 12) and the browser was Google Chrome. I now gave it a try with Opera as well (mobile browser) and with Google Chrome on another Xiaomi Device (Mi 10T Lite, Android 11). Same issue in all cases...

from swiffy-slider.

nicped avatar nicped commented on June 30, 2024

Ok - seems to be Android only issue. Cannot reproduce in any browsers on other devices... But got it reproduced on an Android.
I think I will not change this as it will probably just cause problems in other devices where it works fine now - and then they will calculate wrong.
Also this issue is related to mobile devices where sliding with touch in most cases is the primary navigation path.

from swiffy-slider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.