Annotation of pods which are started by a Job about velero-volume-controller HOT 8 CLOSED

@sevenval-admins First of all, velero will proceed to the backup even though one of podvolumebackups fails.

Is it possible for the controller to remove the annotation when the Pod exits?
Or is there a much better solution to my problem?

IMO, maybe velero-volume-controller should only add annotation to running pod and drop relevant annotation when pod status changes. I will do that later and welcome your PR if it is urgent.

from velero-volume-controller.

It is right that Velero continues with the backup. But the status at the end is PartiallyFailed, which is not good for monitoring the backups.

Unfortunately I can't contribute any PR, because my coding knowledge is not sufficient for that.

from velero-volume-controller.

@duyanghao I can try to look at that. But I don't know if I prefer to ignore pods controlled by a job or/and pod not running. The problem if we simply ignore not running pods, is that we can annotate a pod started by a job, and that this pods terminated during a velero backup.

from velero-volume-controller.

The controller add the annotation to a new pod. I think that it should remove the annotation when the pod is not tunning anymore (error, completed...). I think that it should not add the annotation while the pod is pending, because restic could not work with these pods.

About this issue, we can add a option in the config to choose if we want to exclude pod issued from a job.

I can start a pull request with these features.

from velero-volume-controller.

I opened a pull request for that. Can you take a look ?

from velero-volume-controller.

@fredgate Thanks for your PR, I will verify it later.

from velero-volume-controller.

@sevenval-admins velero-volume-controller now supports excludeJobs option, please try with this feature and feel free to reopen this issue if this problem remains unresolved

from velero-volume-controller.

@duyanghao Great. Thanks. Will try the option.

from velero-volume-controller.