Giter Club home page Giter Club logo

Comments (4)

DusanKasan avatar DusanKasan commented on August 15, 2024 1

Good idea. But i decided not to rename it for now, since when you are using it as a function, you don't have to provide full namespace because count() would conflict with the core count() function. We'll see if people complain about it.

Also, implementing the Countable will probably never happen as it doesn't make sense when we already have the method and we don't want to encourage users to call count().

from knapsack.

DusanKasan avatar DusanKasan commented on August 15, 2024

Further thinking and tinkering:

  • Can't implement ArrayAccess as it implies mutability
  • Should not implement Countable as users should use the provided method instead
  • size() should probably be renamed to count() in next major release as it's more familiar

from knapsack.

sagikazarmark avatar sagikazarmark commented on August 15, 2024

size() should probably be renamed to count() in next major release as it's more familiar

You could deprecate it, create count and make size an alias of it.

from knapsack.

sagikazarmark avatar sagikazarmark commented on August 15, 2024

No problem with size, just wanted to provide a solution for the BC issue.

from knapsack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.