Comments (4)
Good idea. But i decided not to rename it for now, since when you are using it as a function, you don't have to provide full namespace because count() would conflict with the core count() function. We'll see if people complain about it.
Also, implementing the Countable will probably never happen as it doesn't make sense when we already have the method and we don't want to encourage users to call count().
from knapsack.
Further thinking and tinkering:
- Can't implement ArrayAccess as it implies mutability
- Should not implement Countable as users should use the provided method instead
- size() should probably be renamed to count() in next major release as it's more familiar
from knapsack.
size() should probably be renamed to count() in next major release as it's more familiar
You could deprecate it, create count and make size an alias of it.
from knapsack.
No problem with size
, just wanted to provide a solution for the BC issue.
from knapsack.
Related Issues (20)
- Use correctly find() with object HOT 2
- Q: Strict collections intersection HOT 4
- Return composed string HOT 3
- New Feature: Allow $default to be a callback HOT 4
- Does this library support diffing recursively? HOT 5
- Extend Collection HOT 3
- Specifying version in composer not working HOT 1
- toArray - Documented vs Current Behavior
- Add merge method HOT 2
- extract method does not support collections of stdClass
- Generify collections using Psalm HOT 5
- Planned features and changes for 11.0.0 HOT 4
- add Export-ignore
- first throws for an empty collection
- Find key?
- slice function params
- PHP 8.0 - uasort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero HOT 2
- usort error on php8 in setOrder(Grid::SORT_DESC) HOT 1
- PHP 8.1 Deprecation: DusanKasan\Knapsack\Collection implements the Serializable interface, which is deprecated
- PHP 8.1 Deprecation: Return type of DusanKasan\Knapsack\Collection::getIterator()
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knapsack.