Add logging when DistributedCacheStateDataFormatter returns null about identityserver HOT 8 CLOSED

Yes, Microsoft should definitely handle this better. Is it better to send a PR to the OIDC handler?

I've investigated possibilities for better handling and unfortunately the current interfaces/function signatures do not allow any improved error handling. The returned value need to be a valid AuthenticationProperties instance or null.

We could add logging every time we return null because the key wasn't found in cache. But it could also be that just a startup message will help enough, #1550.

My suggestions is to put this on hold for the time being, merge #1550 and see if that is enough.

from identityserver.

Yes, closing for now. If support indicates that people are still confused by this even with the new logging we can reopen.

from identityserver.

Is there something that the MS code could do better here? They should report a different thing, it seems -- IOW, there's "no data to unprotect" vs. "the unprotecting of the data found has failed".

from identityserver.

Yes, Microsoft should definitely handle this better. Is it better to send a PR to the OIDC handler?

from identityserver.

Well, we should start by opening an issue with them. // @Tratcher

from identityserver.

Over here please: https://github.com/dotnet/aspnetcore

FYI, I don't work on AspNetCore anymore.

from identityserver.

Over here please: https://github.com/dotnet/aspnetcore

Thank you!

FYI, I don't work on AspNetCore anymore.

Ah, what's your focus these days?

from identityserver.

So should we close this now, given the PR is merged?

from identityserver.