Comments (7)
mvdoc
commented on June 23, 2024
well -- why not? we use it, so it's referenced :-)
from duecredit.
yarikoptic
commented on June 23, 2024
but we are not using any duecredited function... how do we know that we don't just import it?
from duecredit.
mvdoc
commented on June 23, 2024
that's fair -- I will look into it
On Sun, Aug 23, 2015 at 3:53 PM, Yaroslav Halchenko <
[email protected]> wrote:
but we are not using any duecredited function... how do we know that we
don't just import it?—
Reply to this email directly or view it on GitHub
#48 (comment).
from duecredit.
mvdoc
commented on June 23, 2024
So I'm looking into this, AFAIU the issue comes from injector.py that is set up to always import the package if the module/functions are imported...but I don't know what would be the safest way to change it since I have to digest the code a bit more. Any suggestion? Here's the relevant debugging output
2015-09-03 16:44:09,730 [DEBUG] Processing delayed injection for sklearn (injector.py:141)
2015-09-03 16:44:09,730 [Level 3] Importing duecredit.injections.mod_sklearn (injector.py:146)
2015-09-03 16:44:09,730 [DEBUG] Performing undecorated import of entries (injector.py:237)
2015-09-03 16:44:09,730 [Level 3] Calling injector of duecredit.injections.mod_sklearn (injector.py:157)
2015-09-03 16:44:09,730 [DEBUG] Adding citation entry BibTeX('@article{pedregosa2... for sklearn:None (injector.py:123)
2015-09-03 16:44:09,730 [DEBUG] Adding citation entry Doi('10.1126/science.113680... for sklearn.cluster.affinity_propagation_:None (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1.1.140.301', key='... for sklearn.cluster.bicluster:SpectralCoclustering (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1.1.135.1608', key=... for sklearn.cluster.bicluster:SpectralBiclustering (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1145/233269.233324'... for sklearn.cluster.birch:Birch (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Url('https://code.google.co... for sklearn.cluster.birch:Birch (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry BibTeX('@inproceedings{este... for sklearn.cluster.dbscan_:dbscan (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1109/34.1000236', k... for sklearn.cluster.mean_shift_:MeanShift (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1109/ICCV.2003.1238... for sklearn.cluster.spectral:discretize (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1109/34.868688', ke... for sklearn.cluster.spectral:spectral_clustering (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1007/s11222-007-903... for sklearn.cluster.spectral:spectral_clustering (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1023/A:101093340432... for sklearn.ensemble.forest:RandomForestClassifier.predict_proba (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry Doi('10.1023/A:101093340432... for sklearn.ensemble.forest:RandomForestRegressor.predict (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Adding citation entry BibTeX('@BOOK{breiman-fried... for sklearn.tree.tree:DecisionTreeClassifier.predict_proba (injector.py:123)
2015-09-03 16:44:09,731 [DEBUG] Process 1 injections for module sklearn (injector.py:175)
2015-09-03 16:44:09,731 [Level 4] Considering 1 records for decoration of None:None (injector.py:197)
2015-09-03 16:44:09,731 [Level 1] Collector added entry pedregosa2011scikit (collector.py:204)
2015-09-03 16:44:09,732 [Level 3] Citing directly None:None since obj_path is empty (injector.py:207)
2015-09-03 16:44:09,732 [Level 3] Done processing injections for module sklearn (injector.py:210)
2015-09-03 16:44:09,732 [Level 1] Returning <module 'sklearn.datasets' from '/usr/local/lib/python2.7/site-packages/sklearn/datasets/__init__.pyc'> (injector.py:276)
from duecredit.
yarikoptic
commented on June 23, 2024
the analysis logic should happen during output, as it was before somewhat -- if there are no references triggered for submodules -- do not output that module reference (unless cite_module=True for that module, as we do for numpy only atm)
from duecredit.
mvdoc
commented on June 23, 2024
Gotcha. Thanks for the hint
from duecredit.
yarikoptic
commented on June 23, 2024
closed by #86
from duecredit.
Related Issues (20)
- Internal failure: VerificationError (cryptography) HOT 4
- Integration with citepy CSL data classes HOT 3
- References are not deduplicated in a bibtex summary HOT 3
- Ci testing fails
- How to cite duecredit? HOT 5
- Use DueCredit for data files HOT 2
- Deprecation warning for due credit. HOT 3
- [wishlist] interface to templating engines (e.g. ninja) to provide users a flexible way to render reports
- [wishlist] option (env var) to not load existing .duecredit.p upon start
- Help adding duecredit HOT 20
- Enable duecredit by default, but without injections
- SciPy injection is outdated HOT 3
- Switch from WARNING to DEBUG for outdated injections etc
- Best practices for integrating conditional dcite decorators into Nipype workflows? HOT 2
- DueCredit internal failure while running <function DueSwitch.dump ... on Windows 10 HOT 5
- Improve usage in Jupyter HOT 2
- Internal error: Both inactive and active collectors should be provided HOT 1
- [wishlist] Can duecredit be exported as codemeta? HOT 1
- DueCredit `cite()` doesn't work and `dcite()` works, but not always HOT 5
- Duecredit API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from duecredit.