Comments (8)
@zekiel Downside to this is that the user would have to download more content to get it working because we have to use some other library which we're not currently planning on using: https://code.google.com/p/swfobject/
I think we should just tolerate this. @sdougbrown @bsstoner any opinion on this?
from zeroclickinfo-spice.
Whoa, I didn't realize we were building FlashDetect into core. Is it used for anything else besides this spice? Can we remove and just add to this spice?
You can get the full version without a lib. It's like 20-30 lines of code for cross-browser detection. Something like this in Chrome/FF: navigator.mimeTypes["application/x-shockwave-flash"].enabledPlugin
It's a little more verbose in IE.
from zeroclickinfo-spice.
@bsstoner Yup, we can do that too, but I thought I should take advantage of FlashDetect since it's already there. It's not used in any other Spice, and a quick grep in the core repo didn't show anything. We should probably move it out of there then.
from zeroclickinfo-spice.
not my area of expertise :) defaulting to your judgement
http://i.imgur.com/50iWAFW.gif
from zeroclickinfo-spice.
@jagtalon @zekiel @bsstoner Seems like this can be closed then?
from zeroclickinfo-spice.
@javathunderman I don't think we've resolved it yet, so we should keep it open.
from zeroclickinfo-spice.
Fixed in #2373
from zeroclickinfo-spice.
@MrChrisW nice 👍
from zeroclickinfo-spice.
Related Issues (20)
- Location Sunrise/Sunset: HOT 2
- Instant answer feature not working for all stocks HOT 1
- Word definitions can't be copied HOT 1
- Translation: Instant answer doesn't work HOT 4
- Quote Of The Day: HOT 1
- BrainyQuote:
- Congress: HOT 1
- Amazon:
- Editor: doesnt show up after searching "editor" HOT 1
- Currency Conversion: HOT 3
- BBC: Access is currently only available to BBC employees HOT 1
- Actor Filmography: queries do not work HOT 1
- NFL Games: Suggestion: Add timezone info
- Actor Filmography: HOT 1
- Editor: not working HOT 3
- Translation Suggestion: Amazon Translate as upstream provider HOT 2
- Dictionary Definition:
- Currency Conversion Not Working HOT 2
- Amazon: HOT 1
- Cryptocurrency: Not rendering IA results HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zeroclickinfo-spice.