Giter Club home page Giter Club logo

Comments (4)

jaredzhou avatar jaredzhou commented on May 26, 2024

Hi, i want to add a r2d2 connection pool to duckdb-rs, the problem is that when creating multiple connection, the Config need to be cloned multiple times, but duckdb_config can only be dropped once. I think we can use Arc<Optionffi::duckdb_config> for config instead, when the Arc strong_count is 1, we can call duckdb_destroy_config method. The problem is we need to change the Connection code with config as well, do you think it is a good idea? or do you have any suggestion @wangfenjin

from duckdb-rs.

wangfenjin avatar wangfenjin commented on May 26, 2024

When we clone Config, can we also clone the inner duckdb_config? That way every connection's config is independent.

Thanks for your interests, I'll assign this issue to you. Happy to review the PR!

from duckdb-rs.

jaredzhou avatar jaredzhou commented on May 26, 2024

yeah, clone duckdb_config can do the job, i will try it

from duckdb-rs.

pricesmith avatar pricesmith commented on May 26, 2024

Can someone show me how this is done?

from duckdb-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.