Giter Club home page Giter Club logo

Comments (5)

ducalex avatar ducalex commented on September 27, 2024

Thanks, I don't know what I was thinking and I added back support for the reset pin!

I agree about the GPIO driver, we need a better system. We don't even currently support the extra buttons X/Y/L/R. Or digital IO for the dpad.

In fact I already built a better system that simply reused the RG_GAMEPAD_MAP and got rid of the GPIO constants but I never merged it. I'll see if I can fix it up and push it soon!

But if you want to do your PR before I do that, feel free to just use the #ifdefs. And if absolutely necessary adding a new driver is also fine.

from retro-go.

ducalex avatar ducalex commented on September 27, 2024

Oh, I just saw you already did your PR ;)

We can continue this conversation there.

from retro-go.

Akrobate avatar Akrobate commented on September 27, 2024

Hello!

Ok understood! So what do you think about my PR?

Just by curiosity you said "We don't even currently support the extra buttons X/Y/L/R", how many are you to working on this project? I though you was the only developper on this project ;-)

from retro-go.

ducalex avatar ducalex commented on September 27, 2024

Just by curiosity you said "We don't even currently support the extra buttons X/Y/L/R", how many are you to working on this project? I though you was the only developper on this project ;-)

There's been a few contributions over the years, that's why I say "we", but yes it's mostly just me :).

Ok understood! So what do you think about my PR?

The code is all good but I needed some time to review the docker changes!

from retro-go.

Akrobate avatar Akrobate commented on September 27, 2024

Ok! Let me know if you need some explanations

from retro-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.