Support introspection into a VersionReq about semver HOT 9 CLOSED

+1. I want to parse a semver and express the implied min/max constraints in a similar constraint syntax (Debian packaging metadata). It'd be real nice if VersionReq predicates were exposed in some way to prevent me having to duplicate all that parsing logic.

from semver.

It looks like semver-parser provides the ability to introspect into its version of VersionReq, but semver has its own version of VersionReq that doesn't allow introspection.

Could semver just use the types from semver-parser, rather than converting to its own?

from semver.

Could semver just use the types from semver-parser, rather than converting to its own?

I would say yes, but in a slightly different way: they should still convert over, but we should evolve VersionReq to be more useful.

Now that we've fully converted over, I want to take a hard look at the whole interface, looking towards a 1.0. These kinds of changes are the things I might want to make.

from semver.

@steveklabnik Why the separate types and conversion between them?

from semver.

They're two separate crates, the conversion means that I don't leak the specific semver-parser into semver's external API.

from semver.

Is there a strong reason to keep them separate rather than unifying them?

from semver.

I like small crates, and keeping concerns separate. One crate for one thing; one handles the conversions, the other has all of the logic for comparisons, etc. it feels like the split between -sys and not to me. Plus, there could be other back ends: maybe that nom parser I tried would work better, or LALRPOP.

But! Part of that is the beauty of < 1.0: I'm not actually sure. We'll see.

On Aug 8, 2016, 19:23 -0400, Josh Triplett [email protected], wrote:

Is there a strong reason to keep them separate rather than unifying them?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#59 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AABsio9cOyLsza_0So_cP-amaGhkpa0Hks5qd7pbgaJpZM4GfolK).

from semver.

I don't know how it could be implemented: for now VersionReq is just a bunch of Predicate's. For me it's not clear how to get a min and max constrains.
How can VersionReq be exposed actually?

from semver.

This is now available in 1.0.0. https://docs.rs/semver/1.0.0-rc.1/semver/struct.VersionReq.html

from semver.