Comments (2)
Hi Hnyman,
thanks for the information and fix!
On Oct 9, 2014, at 16:16 , hnyman [email protected] wrote:
When I tried the last change to sqm (8e42148#diff-c0e2726c9acd18d9adb638d16edc764eR128) in my Openwrt build for ar71xx (based on kernel 3.10.49), the script choked on the creation of the new ifb (line 128).
The command "ip link add" seems to require the "name" keyword before the name of the ifb being created.
root@OpenWrt:/# ls -d /sys/devices/virtual/net/ifb*
/sys/devices/virtual/net/ifb0
root@OpenWrt:/# ip link add ifb4eth1 type ifb
Error: argument "ifb4eth1" is wrong: Unknown device
root@OpenWrt:/# ip link add name ifb4eth1 type ifb
root@OpenWrt:/# ls -d /sys/devices/virtual/net/ifb*
/sys/devices/virtual/net/ifb0 /sys/devices/virtual/net/ifb4eth1—
Reply to this email directly or view it on GitHub.
Waho that is fast, I just saw an e-mail on openwrt-devel to that regard and thought about checking this tonight ;) I will test this tonight (just to make sure this also holds true for cerowrt’s ip binary) and check it in the SQM repo (unless someone else beats me to it). The ip-link man page makes it look like “name” is optional so this might be a temporary change in the ip binary (or the man-page might have bit rotted), Anyway I will fix this later….
Best Regards
Sebastian=
from ceropackages-3.10.
Helle Hnyman,
On Oct 9, 2014, at 16:16 , hnyman [email protected] wrote:
When I tried the last change to sqm (8e42148#diff-c0e2726c9acd18d9adb638d16edc764eR128) in my Openwrt build for ar71xx (based on kernel 3.10.49), the script choked on the creation of the new ifb (line 128).
The command "ip link add" seems to require the "name" keyword before the name of the ifb being created.
root@OpenWrt:/# ls -d /sys/devices/virtual/net/ifb*
/sys/devices/virtual/net/ifb0
root@OpenWrt:/# ip link add ifb4eth1 type ifb
Error: argument "ifb4eth1" is wrong: Unknown device
root@OpenWrt:/# ip link add name ifb4eth1 type ifb
root@OpenWrt:/# ls -d /sys/devices/virtual/net/ifb*
/sys/devices/virtual/net/ifb0 /sys/devices/virtual/net/ifb4eth1—
Reply to this email directly or view it on GitHub.
As expected that change works well with cerowrt’ 3.10.50-1’s ip binary, so checked in… (Note I will need to overhaul the stop routine in the near future as currently proper clean up is only performed if the user first deselects the “enable” checkbox followed by a “save & apply” before changing the interface name; otherwise there are left overs from the previous config…)
Best Regards
Sebastian
from ceropackages-3.10.
Related Issues (9)
- sqm-scripts: Cerowrt default "ge00" gets applied when stopping SQM HOT 9
- SQM: unnecessary dependencies for iptables-mod-filter and iptables-mod-conntrack-extra ? HOT 4
- HTB warning message in the kernel. HOT 1
- fix var DEFAULTS from m (manual) to none for some packages, as "m" forced dependencies to be build HOT 3
- Remove sched_fq_pie dependency from tc-adv until it can compile so that Cake shaper can be installed HOT 5
- Syslog Error Message HOT 22
- recursive dependency HOT 3
- Add sqm-scripts to OpenWrt? HOT 26
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ceropackages-3.10.