Comments (15)
@ds300 friendly bump - the changes look very minimal - just changing require('child_process').execSync
to require('child_process').exec
I would submit a PR if you can confirm your willingness to accept it.
simply-vat@59b0064#diff-f37164ed621e6f1db870a6fa99420258869ae02f4e9d0a3de9e75a5d7910065cR4
from postinstall-postinstall.
It's fixed the issue for us @2xAA and we haven't had any problems with it IIRC
this is the important change: simply-vat@59b0064#diff-f37164ed621e6f1db870a6fa99420258869ae02f4e9d0a3de9e75a5d7910065cR4
from postinstall-postinstall.
@slapbox I never got this problem locally, only when running the package in some Linux box for our CI (that I'm admittedly not too familiar with the set up for).
It happened when we upgraded to Node 18, along with bumping the versions of a bunch of dependencies.
from postinstall-postinstall.
same here
error /xxxx/react-native/node_modules/postinstall-postinstall: Command failed.
Exit code: 1
Command: node ./run.js
Arguments:
Directory: /xxxx/react-native/node_modules/postinstall-postinstall
Output:
error Command failed with exit code 1.
child_process.js:669
throw err;
^
Error: Command failed: yarn run postinstall
error Command failed with exit code 1.`
at checkExecSyncError (child_process.js:629:11)
at execSync (child_process.js:666:13)
at Object.<anonymous> (/xxxx/react-native/node_modules/postinstall-postinstall/run.js:15:5)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
Using
yarn 1.22.4
node v10.20.1
from postinstall-postinstall.
@ds300 Hi there, sorry for waking you up, this is currently causing us a little headache - is there anything you can do about it?
It's pretty difficult for us to patch it without having to maintain our own version of the package (since any patches using the patch-package
dependency rely on this package).
from postinstall-postinstall.
@welljsjs - is https://github.com/simply-vat/postinstall-postinstall a stable fix?
from postinstall-postinstall.
@ds300 it's hurting our project as well, please take a look if you'll have a chance
from postinstall-postinstall.
@ds300 it would be great if this issue could get fixed. We've been using patch-package
without issue on Linux, but it's failing for us on Windows.
It's sort of strange that postinstall-postinstall
is neglected when your wildly popular patch-package
depends on it. Now I'm not sure how to proceed.
from postinstall-postinstall.
@slapbox @junipera, using exec succeeds because exec requires callback, it is async. You just ignore error and output when changing to exec. Also you break shouldUseYarn function as it will succeed every time.
from postinstall-postinstall.
It seems like the real error is being swallowed for some reason. When I got this error running patch-packages in our CI, it was because a patch failed to be applied as the patch was considered invalid.
Fixing the patch error also fixed this error.
from postinstall-postinstall.
@sivakusayan are you still seeing this with 8.x
? I don't recall having seen this for some time now.
from postinstall-postinstall.
I was having the same issue, but it was caused by some no longer needed patch files, that I forgot to remove.
from postinstall-postinstall.
What's the latest with this issue? Is there a recommended approach to getting around it?
The above fork seems to now be deprecated:
https://github.com/simply-vat/postinstall-postinstall
from postinstall-postinstall.
@slapbox I never got this problem locally, only when running the package in some Linux box for our CI (that I'm admittedly not too familiar with the set up for).
It happened when we upgraded to Node 18, along with bumping the versions of a bunch of dependencies.
Were you able to resolve it? We're having the same problem after upgrading Node to 18 (from 16). The postinstall fails only in CI however sometimes it succeeds and sometimes fails. Strange.
from postinstall-postinstall.
For me it was also an issue as part of the CI/CD process running Node.js 18.
It looks like this package has long been abandoned with no notable activity in 5+ years and this issue open for since 2019. I was lucky to be able to patch the issue I needed postinstall
for at source but for other cases I would suggest using another package.
from postinstall-postinstall.
Related Issues (8)
- how to trigger
- Cannot install
- v2.1.0? HOT 1
- Running the postinstall hook twice is surprising and unexpected, especially with suppressed output
- Package assumes install of npm (does not allow yarn instead) HOT 1
- Package assumes the availability of yarn HOT 2
- Make postinstall-postinstall work with npm HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postinstall-postinstall.