Comments (10)
Hi @grempe, thanks for the report. It looks like we could fix the bulk of these by initialising a class @schema
ivar inside Dry::Types::Struct
. Probably inside .inherited
where some of the other class ivars are being prepared. Would you you be happy to take a look?
from dry-types.
Hi @timriley
It seems you have a much better handle on the fix than I. Unfortunately I don't have the time at the moment to track this down, figure out what it should be initialized to, and test the issue.
I'll have to leave it with you for now.
from dry-types.
@AMHOL can we do something about these warnings on container/conifgurable side too?
from dry-types.
I'll have a look
from dry-types.
Guys is this still actual?
I ran rake test
in provided project and got:
Looks like it could be closed for now.
from dry-types.
@sclinede did you enable warnings? not sure if rake test
does that by default
from dry-types.
@solnic sorry, my fault. Reproduced it. I'll take a look what I can do) 👍
from dry-types.
OK.
Now I see that we need several solutions, as problem reproduced on all of those cases:
- for 0.7.x version, (in what branch should I open PR ?)
- for 0.8.x version - implementation changed a bit (in what branch should I open PR, too ?)
- master - Dry::Types::Struct is moved to dry-struct (maybe I should send PR to dry-struct)
@solnic ?
from dry-types.
@sclinede we only care about master and future releases, there's no need to fix in older versions :)
from dry-types.
ok. so I'll open PR in dry-struct and link to that issue.
from dry-types.
Related Issues (20)
- Anonymous Dry::Types based module cannot be extended HOT 4
- Params namespace disapearing HOT 9
- Params coercion for Array works in an unintuitive way HOT 1
- https://dry-rb.org/gems/dry-types/ not at latest version HOT 1
- [Security] Workflow ci.yml is using vulnerable action actions/checkout
- Compound Types with Examples HOT 1
- Dry::Container::Error: There is already an item registered with the key "nominal.string" on jruby-head HOT 4
- Future-proof local override for Types::Instance/Constructor classes that potentially collide with predicates
- Unexpected error raised from Sum type HOT 7
- Types::Coeercible::Integer, should this use Base 10? HOT 2
- Add Zeitwerk autoloader
- Using transform_keys breaks error handling
- Undefined method after upgrading dependencies. HOT 5
- Missing method implementation for `Enum.each_value` HOT 1
- Types.Constructor failing on Ruby 3.1 HOT 8
- A bug with array, struct and sum of structs in `try` method
- Fix BigDemical warning
- default causes try/1 to raise an ConstraintError exception rather than an Failure
- Dry-Types Gem Issue with Coercing Float Strings to Integers HOT 1
- No obvious way to use nullary predicates in constraints HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dry-types.