Giter Club home page Giter Club logo

Comments (10)

timriley avatar timriley commented on August 15, 2024

Hi @grempe, thanks for the report. It looks like we could fix the bulk of these by initialising a class @schema ivar inside Dry::Types::Struct. Probably inside .inherited where some of the other class ivars are being prepared. Would you you be happy to take a look?

from dry-types.

grempe avatar grempe commented on August 15, 2024

Hi @timriley

It seems you have a much better handle on the fix than I. Unfortunately I don't have the time at the moment to track this down, figure out what it should be initialized to, and test the issue.

I'll have to leave it with you for now.

from dry-types.

solnic avatar solnic commented on August 15, 2024

@AMHOL can we do something about these warnings on container/conifgurable side too?

from dry-types.

AMHOL avatar AMHOL commented on August 15, 2024

I'll have a look

from dry-types.

sclinede avatar sclinede commented on August 15, 2024

Guys is this still actual?
I ran rake test in provided project and got:
screenshot at 2016-08-10 18 00 06

Looks like it could be closed for now.

from dry-types.

solnic avatar solnic commented on August 15, 2024

@sclinede did you enable warnings? not sure if rake test does that by default

from dry-types.

sclinede avatar sclinede commented on August 15, 2024

@solnic sorry, my fault. Reproduced it. I'll take a look what I can do) 👍

from dry-types.

sclinede avatar sclinede commented on August 15, 2024

OK.
Now I see that we need several solutions, as problem reproduced on all of those cases:

  1. for 0.7.x version, (in what branch should I open PR ?)
  2. for 0.8.x version - implementation changed a bit (in what branch should I open PR, too ?)
  3. master - Dry::Types::Struct is moved to dry-struct (maybe I should send PR to dry-struct)

@solnic ?

from dry-types.

solnic avatar solnic commented on August 15, 2024

@sclinede we only care about master and future releases, there's no need to fix in older versions :)

from dry-types.

sclinede avatar sclinede commented on August 15, 2024

ok. so I'll open PR in dry-struct and link to that issue.

from dry-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.