Giter Club home page Giter Club logo

Comments (4)

davispuh avatar davispuh commented on August 15, 2024

this doesn't work too

class Shelf < Dry::Data::Value
  attribute :books,     Types::Strict::Array.member(Types::Maybe::Strict::String)
end

class Room < Dry::Data::Value
  attribute :shelf, Shelf
end

shelf = Shelf.new(:books => ['Some book'])

puts Room.new(:shelf => shelf).inspect
/usr/lib/ruby/gems/2.3.0/gems/dry-data-0.5.1/lib/dry/data/struct.rb:36:in `rescue in new': [Room.new] #<Shelf books=[Some("Some book")]> (Shelf) has invalid type for :shelf (Dry::Data::StructError)
        from /usr/lib/ruby/gems/2.3.0/gems/dry-data-0.5.1/lib/dry/data/struct.rb:34:in `new'

from dry-types.

solnic avatar solnic commented on August 15, 2024

Thanks for the report. I'll fix it in the next release.

from dry-types.

marshall-lee avatar marshall-lee commented on August 15, 2024

@solnic more generic problem:

class X
end
Dry::Types.register_class(X)
Dry::Types[X][X.new] # ArgumentError: wrong number of arguments (given 1, expected 0)

This:

class Y < Dry::Types::Struct
  attribute :y, Types::Strict::String
end
type = Dry::Types[Y]

attributes = { y: '---' }
y = Y.new(attributes) # => #<Y:0x00000004ed0d88 @y="---">
type[attributes] # => #<Y:0x00000004d265c8 @y="---">
type[y] # => #<Y:0x00000004f0bd48 @y="---">

Works just by occasion, because y responds to [] just like attributes.

I think that Type#[] should not recreate instances that are already valid. If your upcoming refactoring solves this issue it would be good.

from dry-types.

solnic avatar solnic commented on August 15, 2024

@marshall-lee it doesn't recreate, or at least it should not. defo a bug, will fix

from dry-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.