Some thoughts on EntityQuery about graphql HOT 5 CLOSED

I also added a 'count' field to the entity query results now. Useful for implementing pagination.

from graphql.

Good point! But what about taking it one step further and use a generated InputType for properties? That way we get a cleaner interface (and remove possible name clashes with limit or offset), but keep type safety and autocompletion.

from graphql.

I don't like the entityPropertyQuery returning EntityInterface. That doesn't make much sense imho simply because of the fact that EntityQuery doesn't work across different entity types.

I do, however, like the idea of putting the properties in an InputObjectType. So, what I'd like to see is this:

nodeQuery(
  offset: Int
  limit: Int
  properties: NodePropertiesInput
): [Node]!

NodePropertiesInput {
  nid: Int
  uuid: String
  vid: Int
  langcode: String
  type: String
  ...
}

from graphql.

Thanks, that's fine with me.

from graphql.

Cool! Would you like to work on that?

from graphql.