Leaves a tmp* directory in application root about drupal-scaffold HOT 12 CLOSED

I tried to reproduce the bug report, but failed. Could you give me more information about your setup/os?

from drupal-scaffold.

Source, Log
Linux Jarvis 4.2.0-35-generic #40-Ubuntu SMP Tue Mar 15 22:15:45 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Composer version @package_branch_alias_version@ (1.0.0) 2016-04-05 13:27:25

I'm likely using the Composer scripts incorrectly.

from drupal-scaffold.

It is also happening for me on ubuntu.

from drupal-scaffold.

Do note the path... [FileSystem\FilesystemStack] mkdir ["/tmp//drupal-scaffold-1460255831"]

/tmp//drupal-*. Would the paths have anything to do with it?

from drupal-scaffold.

Tagged a new release with #28 and #30

from drupal-scaffold.

This is not fixed yet. The problem is apparently in robo extract/rename task. The extract task extract the file in some random tmp directory in project root. In RoboFile.php we have

$extract = $this->taskExtract($archivePath)->to("$tmpDir/$fetchDirName")->run();

And in Extract.php we have

            if ($hasEncapsulatingFolder && !$this->preserveTopDirectory) {
                $result = (new FileSystemStack())->rename($filesInExtractLocation[0], $this->to)->run();
                @rmdir($extractLocation);
            }

The directory $extractLocation is not empty so it is not deleted. $extractLocation is not empty because FilesystemStack::_rename just copies the content to target and doesn't empty $origin.

from drupal-scaffold.

There was fix in consolidation/robo#276 but then there was consolidation/robo#277 cc: @greg-1-anderson.

from drupal-scaffold.

Hmm but, robo 0.7.* is required by drupal-composer/drupal-scaffold already.

from drupal-scaffold.

@jibran @RobLoach could you try again with the latest release?

from drupal-scaffold.

@jibran @RobLoach There were still a couple of cross-volume rename bugs in Robo. This is not too surprising, considering that there were no cross-volume rename tests on Travis (since Travis does not have multiple volumes available). I refactored the code so that the cross-volume rename method was testable on a single volume, fixed the bugs, added a test, and tagged Robo 0.7.2. Please run composer update, ensure that you got Robo 0.7.2, and see if it clears up your problems.

from drupal-scaffold.

Thanks @greg-1-anderson robo 0.7.2 fixed the problem for me. Thanks @webflo for looking into it.

from drupal-scaffold.

Thanks for your patience, all.

from drupal-scaffold.