Giter Club home page Giter Club logo

bfnavigationbardrawer's People

Contributors

brocoo avatar drummerb avatar zzz6519003 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bfnavigationbardrawer's Issues

showFromNavigationBar:animated: is not idempotent

If you call this method twice after having set a scrollView:

    self.toolbar.scrollView = self.collectionView;
    ...
    [self.toolbar showFromNavigationBar:self.navigationController.navigationBar animated:NO];
[self.toolbar showFromNavigationBar:self.navigationController.navigationBar animated:NO];

The contentInset continues to be padded from the top multiple times.

I expect the toolbar to remember its showing state for the nominated navigationBar. (Or, indeed, know what bar it was previously shown from as well) It should not augment the contentInset multiple times.

Crash at line 240 of BFNavigationBarDrawer.m

Here are the logs.

screen shot 2015-05-22 at 5 54 40 pm

I am calling the hideAnimated method from my view controller's viewWillDisappear. It is important to note that this crash doesn't happen most of the time.

Does not animate / work properly on device rotations

Thanks for BFNavigationBarDrawer โ€” it's probably saved me hours of trying to get a toolbar attached to the navigation bar.

When the toolbar is shown in either landscape or portrait orientations, it's fine.
However, when you rotate the device 90 degrees, it's obvious that the toolbar remains oblivious.

In particular, I have a segmented control placed bang in the middle of the toolbar so it's very obvious that the toolbar has not reacted to the new orientation.

My workaround for this is something like the following:

- (void)didRotateFromInterfaceOrientation:(UIInterfaceOrientation)fromInterfaceOrientation {
    [super didRotateFromInterfaceOrientation:fromInterfaceOrientation];
    // 
    [self.toolbar hideAnimated:NO];
    [self.toolbar showFromNavigationBar:self.navigationController.navigationBar animated:NO];
}

It's not perfect: you see the segmented control 'jumping' into its correct position this way.

I expect the toolbar to react naturally to bounds changes like the one caused by a device rotation.

drawer on top "Without scroll view adjustment"

Hello,
thank you for this solution.
Can you provide a the configuration, so when the drawer is scrolling down not to push the tableview scroller(like the "Without scroll view adjustment" in your image)?

Thanks in advance

isShowing method

It's useful to check whether the toolbar is currently shown.

What's the best way of doing this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.