Giter Club home page Giter Club logo

Comments (2)

DanielPlainview avatar DanielPlainview commented on August 30, 2024

Furthermore, protoc-gen-php saves files (multifile) with following structure:

<...>/BidRequest.php
<...>/BidRequest/UserList.php
<...>/BidResponse.php
<...>

but I'd except

<...>/Google/Rtb/BidRequest.php
<...>/Google/Rtb/BidRequest/UserList.php
<...>/Google/Rtb/BidResponse.php
<...>

from protobuf-php.

DanielPlainview avatar DanielPlainview commented on August 30, 2024

Hi,

I've found out I still use hack in DrSlump\Protobuf\Compiler like

        foreach($req->getProtoFileList() as $proto) {
            $package = $proto->getPackage();
            $namespace = $generator->getNamespace($proto);
            if (isset($this->packages[$package]) && $namespace !== $this->packages[$package]) {
                $this->warning("Package $package was already mapped to {$this->packages[$package]} but has now been overridden to $namespace");
            }
            $this->packages[$package] = $namespace;
            $this->notice("Mapping $package to $namespace");

            PackageMap::map($this, $namespace); // hack
        }
use DrSlump\Protobuf\Compiler;

class PackageMap
{
    private static $packageList = array(
        'BidRequest',
        'BidRequest.AdSlot',
        'BidRequest.AdSlot.MatchingAdData',
        'BidRequest.AdSlot.MatchingAdData.DirectDeal',
        'BidRequest.AdSlot.SlotVisibility',
        'BidRequest.KeyValue',
        'BidRequest.MatchingNetwork',
        'BidRequest.Mobile',
        'BidRequest.Mobile.DeviceOsVersion',
        'BidRequest.Mobile.MobileDeviceType',
        'BidRequest.Mobile.ScreenOrientation',
        'BidRequest.UserList',
        'BidRequest.Vertical',
        'BidRequest.Video',
        'BidRequest.Video.CompanionSlot',
        'BidRequest.Video.CompanionSlot.CreativeFormat',
        'BidRequest.Video.InventoryType',
        'BidRequest.Video.SkippableBidRequestType',
        'BidRequest.Video.VideoFormat',
        'BidResponse',
        'BidResponse.Ad',
        'BidResponse.Ad.AdSlot',
        'BidResponse.Ad.TemplateParameter'
    );

    public static function map(Compiler $compiler, $namespace)
    {
        foreach (self::$packageList as $package) {
            $compiler->setPackage($package, self::normalize($namespace.'.'.$package));
        }
    }

    private static function normalize($ns)
    {
        return strtr($ns, '.', '\\');
    }
}

Any chance to fix it properly?

from protobuf-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.