Comments (1)
Hi @kfigiela
As you can see in the documentation there is an other option to set "Cache-Control" as metadata.
"http://docs.aws.amazon.com/sdk-for-go/api/service/s3.html#type-PutObjectInput"
If you set via "metadata" you will get "x-amz-meta-cache-control", so it have to be set directly via "Cache-Control".
So its not a bug, its just not implemented.
More or less like this (Sorry markdown dont let me format this 👎 ):
var cacheControl string
if a.vargs.CacheControl.IsString() {
cacheControl = a.vargs.CacheControl.String()
} else if !a.vargs.CacheControl.IsEmpty() {
contentMap := a.vargs.CacheControl.Map()
for patternExt := range contentMap {
if patternExt == fileExt {
cacheControl = contentMap[patternExt]
break
}
}
}
_, err = a.client.CopyObject(&s3.CopyObjectInput{
Bucket: aws.String(a.vargs.Bucket),
Key: aws.String(remote),
CopySource: aws.String(fmt.Sprintf("%s/%s", a.vargs.Bucket, remote)),
ContentType: aws.String(contentType),
ContentEncoding: aws.String(contentEncoding),
CacheControl: aws.String(cacheControl),
ACL: aws.String(access),
Metadata: metadata,
MetadataDirective: aws.String("REPLACE"),
})
from drone-s3-sync.
Related Issues (20)
- Support content-encryption HOT 5
- docs mention exclude and include but these functions are not implemented HOT 2
- Delete option sometimes doesn't work as anticipated HOT 1
- sync stops with AWS error "NoSuchKey" HOT 4
- Submit documentation to plugins.drone.io HOT 1
- Documentation is confusing for the bucket parameter HOT 5
- 501 during upload HOT 5
- Plugin can't work if AWS keys are not set (use the given role) HOT 3
- Passing secrets not working as intended HOT 4
- Support for CloudFront invalidation with given path. HOT 2
- The ability to exclude paths/files HOT 1
- Support configuring Cache-Control headers per path HOT 5
- acl configuration in yaml does not work HOT 1
- Would the transfer result only successful or failed? HOT 2
- strange endpoint addition HOT 4
- Problem with Syncing S3 with invalidation of Cloudfront distribution when key has white space on beggining.
- Is there a way to `strip_prefix` like the s3 plugin?
- doesn't support private s3 buckets HOT 1
- blank content type for .mjs files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drone-s3-sync.