Giter Club home page Giter Club logo

Comments (6)

mrliptontea avatar mrliptontea commented on May 30, 2024

The while loop's condition is incorrect.

First of all, there should be and, not or because it should break if any of this is true. The break word at line 130 is not necessary.
Secondly, sel.b never reaches -1. So this will turn to infinite loop always if a current line does not contain the keywords given|when|then, which is bad for i18n support.

from cucumber-sublime-bundle.

drewda avatar drewda commented on May 30, 2024

@mrliptontea thanks for reporting this error. Could you open a pull request with your proposed fix?

from cucumber-sublime-bundle.

mrliptontea avatar mrliptontea commented on May 30, 2024

I need to look into this, as I don't understand all the parts of this code.
To fix all the issues I've noticed here it might require a rewrite of quite a bit.

from cucumber-sublime-bundle.

danielkza avatar danielkza commented on May 30, 2024

I'm still seeing this, makes the plugin completely unusable. Any chance to merge that PR?

from cucumber-sublime-bundle.

maciejmyslinski avatar maciejmyslinski commented on May 30, 2024

It happends me too. OSX.

from cucumber-sublime-bundle.

drewda avatar drewda commented on May 30, 2024

A belated "thank you" for your fix, @mrliptontea.

from cucumber-sublime-bundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.