Giter Club home page Giter Club logo

Comments (8)

Drakulix avatar Drakulix commented on July 26, 2024

Yes, this was introduced by 084d57a .

I can easily make this configurable via the ConfigBuilder.

from simplelog.rs.

Drakulix avatar Drakulix commented on July 26, 2024

I have introduced a new config option on branch feature/config_padding (see #45).
@evitalis can you verify, that this fixes your issue?

If it does, I'll update the examples and release it as 0.7.2 shortly.

from simplelog.rs.

 avatar commented on July 26, 2024

Thanks. I can check it out a bit later today. Is it possible to use the defaults and only override this one setting by chance?

from simplelog.rs.

Drakulix avatar Drakulix commented on July 26, 2024

Thanks. I can check it out a bit later today. Is it possible to use the defaults and only override this one setting by chance?

Yes, just set this in the ConfigBuilder and ignore the rest. Then pass the built config to your logger.

from simplelog.rs.

 avatar commented on July 26, 2024

Seemed to work for me using my example code as a test. Do you think it may be worth setting the padding to off by default instead of the left padding?

from simplelog.rs.

Drakulix avatar Drakulix commented on July 26, 2024

Seemed to work for me using my example code as a test. Do you think it may be worth setting the padding to off by default instead of the left padding?

I think I do not want to change the semantics of the default values without a major version break to make people aware. And since simplelog had quite a lot major releases recently I will probably delay this decision for now.

Maybe I should open an issue on defaults in general, some other users might have something to say about it as well.

But I am glad this is working, I will release it soon in that case.

from simplelog.rs.

 avatar commented on July 26, 2024

Makes sense, maybe on 0.8 the default could be off or right. I am curious why it ends up being left padded though, Western languages usually right pad since they are read left to right.

In any event thanks for the quick update to this.

from simplelog.rs.

Drakulix avatar Drakulix commented on July 26, 2024

Makes sense, maybe on 0.8 the default could be off or right. I am curious why it ends up being left padded though, Western languages usually right pad since they are read left to right.

Yes, 0.8 should absolutely change this. If you are interested where this came from: #35.

from simplelog.rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.