Comments (7)
sourvad
commented on June 18, 2024
@dpalmasan Can I work on this issue?
from trunajod2.0.
dpalmasan
commented on June 18, 2024
@sourvad sure! Feel free to work on this issue
from trunajod2.0.
sourvad
commented on June 18, 2024
Hello @dpalmasan ,there is no docstring for the following parameters:
-
In lexical_diversity_mtld:
- model_name
- ttr_segment
-
In one_side_lexical_diversity_mtld:
- model_name
Should type hints be added for these parameters as well, or is it abstracted away by design?
from trunajod2.0.
dpalmasan
commented on June 18, 2024
Good catch! @sourvad Probably we need to also update the docstrings
from trunajod2.0.
sourvad
commented on June 18, 2024
Gotcha, will do.
from trunajod2.0.
sourvad
commented on June 18, 2024
@dpalmasan I believe it's done. Build passed and ran pre-commit.
from trunajod2.0.
dpalmasan
commented on June 18, 2024
PR merged, closing.
from trunajod2.0.
Related Issues (20)
- Add type hints to lexico semantic norms HOT 1
- Add type hints to semantic_measures.py HOT 1
- Add type hints to surface_proxies
- Add type hints to syllabizer HOT 3
- Add type hints to utils
- Specify Python version HOT 1
- Paper grammar review HOT 2
- Missing community guidelines HOT 2
- Error while running example HOT 5
- State of the field HOT 3
- Include additional examples on the documentation HOT 3
- Complete / expand contribution guidelines HOT 2
- Fix typo in Yule's K
- Add word variation index
- Improve `is_word` function HOT 1
- Implement universal POS tags ratio
- Implement Salience model for Entity Grid
- Documentation is inconsistent with current released version
- Add givenness approximation based on semantic measurements
- Add coherence measurements based on syntactic patterns
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trunajod2.0.