Settings conflict prevents automatic language redirection about nlingual HOT 4 CLOSED

Dropped in a PR for changes that make this behave the way I expected it to. I tried some other things to see if it broke anything, and didn't find any issues, but of course didn't try every possible combination of settings. Notably I'm not set up to easily test that I didn't mess up subdirectory-based translation redirection, somehow, though I think I've not done anything that should affect that. Didn't see any automated tests to run so I just poked at things I thought might have been messed up by these changes, and didn't find anything.

from nlingual.

Will take a look; been juggling a few too many rush projects at work.

It is indeed an issue but it's also arguably a limitation that should be expressed better by the settings. I don't want to prevent someone who's browser language is, say, french, from being able to view the site in english for whatever reason. This could always be overwritten with a GET arg on the URLs of course. I may have even fixed this partially on one of the other branches I've yet to merge (recent development has been a bit... chaotic).

Until I'm able to publish a semi-thorough patch, you should be able to use the available hooks to make the changes you want.

from nlingual.

Cool, thanks for the response! More details about the exact issue in the PR, let me know if you have any questions about it. Meanwhile, I'll look at a hook-based workaround, as suggested.

from nlingual.

Hey, finally had some time to look at this in detail, working on a patch soon that should solve this sanely.

Basically, I've rewritten the handling of skip_default_l10n to not apply when the browser's language matches a non-default supported language. This allows, for example, a french visitor to be redirected to the french page (unless post_language_override is set, it takes precedence), but if they want to they can view the english pages by visting URLs with /en/ specified (or en.* in the case of subdomain handling... which come to think of it I almost never test).

I'm not sure that made sense so here's an outline of scenarios for an english/french site:

I've gotta test it on a few dev sites to make sure first. Should have this ironed out into a proper update next week, provided a certain project doesn't spontaneously return from limbo.

from nlingual.