Giter Club home page Giter Club logo

Comments (7)

xanonid avatar xanonid commented on June 26, 2024 1

Works also meanwhile with recent node v12.x versions (>= v12.16.x).

from nodejs-depd.

dougwilson avatar dougwilson commented on June 26, 2024

The --enable-source-maps is still experimental. Usage of it breaks the Error.prepareStackTrace v8 API this module relies on (among other things).

Node.js allows you to hook in with Error.prepareStackTrace global (https://github.com/nodejs/node/blob/cbd8d715b2286e5726e6988921f5c870cbf74127/lib/internal/errors.js#L37) but when you set --enable-source-maps they replace the error stack functionality with something that doesn't do this (https://github.com/nodejs/node/blob/4ca61f40fed31d590e4d624551044fe7cc7efd42/lib/internal/source_map/prepare_stack_trace.js). I would assume this is a bug / accident on their part unless there is something that says otherwise.

I would suggest raising the bug on Node.js based on this.

from nodejs-depd.

dougwilson avatar dougwilson commented on June 26, 2024

Here is a simplified example of the underlying issue:

$ node -e 'Error.prepareStackTrace=()=>console.log("called");new Error().stack'
called
$ node -e 'Error.prepareStackTrace=()=>console.log("called");new Error().stack' --enable-source-maps
$

from nodejs-depd.

dougwilson avatar dougwilson commented on June 26, 2024

nodejs/node#29994

from nodejs-depd.

dougwilson avatar dougwilson commented on June 26, 2024

Keeping open for visibility

from nodejs-depd.

soda0289 avatar soda0289 commented on June 26, 2024

Fixed in node v13.6.0

@dougwilson Thanks for reporting to nodejs

from nodejs-depd.

sla100 avatar sla100 commented on June 26, 2024

Cum debita reverentia

from nodejs-depd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.