Most checks with c++ files fail with "Error while processing" (v0.3.3) about cppnamelint HOT 12 CLOSED

I randomly selected a simple code repo from github: https://github.com/changkun/modern-cpp-tutorial
all .cpp files are failing with
cppnamelint check -config cppnamelint.toml ...

Note: I cross-checked with the code of cppnamelint - no issues

from cppnamelint.

I have some more findings and will create a follow up ticket

from cppnamelint.

looks like it fails here:
Common.cpp / 147:
if (0 == Tool.run(NewFactory.get())) {

HTH

from cppnamelint.

Hi @ruedbi ,

Recently, I am trying to merge this major functions to Clang-Tidy, Clang-Tidy provides enormous static analysis checks for source code and it is an official utility too. So I made a patch for integration. You can find it with the link, https://reviews.llvm.org/D86671. If you need those functions, could you do me a favor to leave a message there, maybe reviewers will review it sooner.

Back to you original topic. If you need it too, can you please give me your code snippets?

from cppnamelint.

CaseType could be interesting, Hungarian notation not so much
what kind of message would help?

from cppnamelint.

Code snippets: You mean the code that causes the processing error?
That is not possible (commercial code), but maybe I find some public code to reproduce the issue.

from cppnamelint.

Code snippets: You mean the code that causes the processing error?
That is not possible (commercial code), but maybe I find some public code to reproduce the issue.

yep, I need it to reproduce.

Maybe you can have it a look to Clang-Tidy, readability-identifier-naming (https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html).

from cppnamelint.

thanks for the hint to readability-identifier-naming, I will check that too
result: not configurable, finds a lot of readabiliy issues, but nothing naming-related (quite unlikely ;-) )

from cppnamelint.

Hi @ruedbi
Sorry for replying you late.

I have fixed the issue, can you have it a try with your project?
https://github.com/dougpuob/cppnamelint/releases/tag/untagged-990be7794a2930c5479c

If you are interested in the details, click here (ef537f9)

Another I told you is incorrect about building this project with newer llvm. I can built it with llvmorg-12.0.0-rc3. There are several issues I will try to improve later (made action items for them).

1. build with newer llvm version (with vcpkg on local and Azure CI/CD) #58
2. change the logger. #59
3. follow-up this issue, why this issue cannot be duplicated on Windows version. #60

Anyway, thank for your report. Please let me know if the issue was fixed with your project, if fixed I will close this issue.

from cppnamelint.

Hi Douglas,

thanks for your bugfix, I highly appreciate that.
The tag was not accessible, so I had to recompile with llvm 8 using ef537f9. This version does not compile with llvm 12 though (not sure if it was to be expected).

Good news: I can confirm that the processing errors are gone. I will proceed testing.

from cppnamelint.

Hi Douglas,

thanks for your bugfix, I highly appreciate that.
The tag was not accessible, so I had to recompile with llvm 8 using ef537f9. This version does not compile with llvm 12 though (not sure if it was to be expected).

Good news: I can confirm that the processing errors are gone. I will proceed testing.

Sounds great! Now you can't build with newer llvm with current CMakeLists.txt. I will update it later (#58 is the follow-up action item).

I created v0.3.4 for it.

from cppnamelint.

Close this issue, because I got the good feedback from @ruedbi .

I have some more findings and will create a follow up ticket

Sure & thank you.

from cppnamelint.