Giter Club home page Giter Club logo

Comments (6)

weshaggard avatar weshaggard commented on June 27, 2024

@akoeplinger @marek-safar Please have a look at e2425ce where I needed to add Xamarin.iOS.dll and OpenTK-1.0.dll to the reference set to correctly generate the facade for the drawing primitives. You guys may want to consider adding a System.Drawing.dll, even if it is only a facade so that you can share the same System.Drawing facade we are generating for netstandard compat.

from standard.

marek-safar avatar marek-safar commented on June 27, 2024

The change looks ok but the newly added assemblies have wrong version number and public key. We don't version them. They both have 0.0.0.0 version and custom public key. @akoeplinger could you PR a fix for that?

About adding System.Drawing facade. I think we tried that some time ago but it was a breaking change but would have to dig out for exact details but I think it was due to user's provided System.Drawing.dll (which is quite common) and some resolution conflicts caused by that.

Another option can be to re-use existing System.Drawing.Primitives.dll facade if you want.

from standard.

weshaggard avatar weshaggard commented on June 27, 2024

Thanks for the information. This does mean we are going to need a unique netstandard facade for you guys as the one we are building for net461 will not just work for you, but that shouldn't be a big deal either way.

from standard.

marek-safar avatar marek-safar commented on June 27, 2024

Yes, this will get more complicated. The netstandard.dll needs to be different for every target platform (android, ios, ios-watch, ios-tv, mac, etc) because we have different set of assemblies there. Something like

ios - has OpenTK + Xamarin.iOS
android - has System.Drawing
ios-watch - has none of that
mac - has OpenTK + Xamarin.Mac

from standard.

weshaggard avatar weshaggard commented on June 27, 2024

OK we will need to figure out how we want to set that up for you to be able to sub-module dotnet/standard and build unique facades for each of those targets. However it shouldn't be too terrible.

from standard.

akoeplinger avatar akoeplinger commented on June 27, 2024

I added the other platforms in #96 with correct version numbers + keys.

from standard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.