Giter Club home page Giter Club logo

Comments (4)

terrajobst avatar terrajobst commented on June 27, 2024 1

We should look at usage from NuGet and APIPort to see whether any APIs are affected that have high usage. Our current goal is parity with Xamarin; so we don't need them. However we also want to make porting from .NET FX to .NET Core easier. So I'd say: let's make sure we don't cut highly used ones. Those, we should ask Xamarin to add and throw, if they can't implement it.

We should add the methods on Marshal which means SecureString has to go into the corlib assembly.

from standard.

weshaggard avatar weshaggard commented on June 27, 2024

Another set of interesting APIs on Marshal to consider are the SecureString marshalling APIs.

        public static System.IntPtr SecureStringToBSTR(System.Security.SecureString s) { throw null; }
        public static System.IntPtr SecureStringToCoTaskMemAnsi(System.Security.SecureString s) { throw null; }
        public static System.IntPtr SecureStringToCoTaskMemUnicode(System.Security.SecureString s) { throw null; }
        public static System.IntPtr SecureStringToGlobalAllocAnsi(System.Security.SecureString s) { throw null; }
        public static System.IntPtr SecureStringToGlobalAllocUnicode(System.Security.SecureString s) { throw null; }

For .NET Core we have SecureString implemeneted as a standalone library and have introduced SecureStringMarshal (https://github.com/dotnet/corefx/blob/master/src/System.Security.SecureString/ref/System.Security.SecureString.cs#L26) to break this dependency. To help support this factoriziation I'm thinking we will remove the SecureString APIs from Marshal.

from standard.

tijoytom-zz avatar tijoytom-zz commented on June 27, 2024

@terrajobst @weshaggard @yizhang82

Here is Marshal.SecureString usage stat
SecureString: APIport :4.4% Nuget : 1.9%

from standard.

weshaggard avatar weshaggard commented on June 27, 2024

Reverted the SecureString Marshal removals with 8fc5b7f.

from standard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.