Comments (4)
While removing the constructor is not a breaking change, adding a parameter would be a breaking change. The analyzer simply points out situations which need to thought about to evaluate if it is a breaking change. It's not worth special-casing this case in the analyzer.
from roslyn-analyzers.
@srivatsn I disagree and kindly recommend to reconsider this desicion. I do not only claim that removal of this constructor declaration is not a breaking change, I do claim that it is not a change at all. It does not change anything in the emitted assembly and is equivalent to re-formatting a code. Forcing a user to update any files to successfully build after this serves no useful purpose, and only places an unnecessary burden on the user.
from roslyn-analyzers.
I don't disagree. I was just saying that it's not an important enough case. I'll reopen the issue and mark it up for grabs. Feel free to submit a PR.
from roslyn-analyzers.
@mavasani Please move to roslyn-analyzers to either fix it or add a test confirming if it was already fixed..
from roslyn-analyzers.
Related Issues (20)
- Warning for disabled reflection-based serialization HOT 4
- Malformed message template string should throw warning or compiler error as a preference over runtime exceptions HOT 10
- CA1849 suggests parameterless async methods to replace synchronous methods with parameters
- CA2254 should not apply when null coalescing expression is used
- CA2000 Use recommended dispose pattern to ensure that object created HOT 1
- incorrect suggestion of CA1854 Prefer a "TryGetValue" call over a Dictionary indexer access guarded by a "ContainsKey" check to avoid double lookup
- `CA2213` triggers when value is assigned in null check
- CA2208 - False positive for specific text in ArgumentException parameter HOT 2
- Roslyn plugins (analyzers, source generators) target .NET 8 instead of .NET Standard 2.0 HOT 2
- CA3001 (taint analysis) doesn't work with interfaces
- Subtype relationship between collection and read-only collection interfaces impacts behavior of analyzers HOT 5
- Required Property has a default property set HOT 2
- CA1851: fails to detect multiple enumeration in certain scenarios
- .NET 9 Preview 3 occassionally fails to build in arm64 with `Object reference not set to an instance of an object` errors HOT 12
- AD0001: Analyzer 'Microsoft.CodeAnalysis.CodeStyle.CSharpFormattingAnalyzer' threw an exception of type 'System.TypeLoadException' HOT 8
- CA1859: False positive for operators and multiple derived types HOT 1
- Attempting to refactor CA1850 crashes refactoring HOT 1
- CA1416 warnings are erroneously shown in lambdas which are only reachable after platform checks
- CA1307 appears unexpectedly when you set CodeAnalysisTreatWarningsAsErrors=false
- CA2016 - Flag cases where called methods accept a CancellationToken
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roslyn-analyzers.