Comments (10)
8
from roslyn-analyzers.
598 in MissingAnalysisMethodAsync
Old:
string methodName = invocationExpression.ArgumentList.Arguments[0].ToString();
New:
var methodIdentifier = invocationExpression.ArgumentList.Arguments[0].Expression as IdentifierNameSyntax;
string methodName = methodIdentifier.Identifier.Text;
from roslyn-analyzers.
1069 in MultipleStatementsAsync
Old:
var expressionStart = expression.Expression as MemberAccessExpressionSyntax;
if (expressionStart == null || expressionStart.Name == null ||
expressionStart.Name.ToString() != "RegisterSyntaxNodeAction")
New:
var expressionStart = expression.Expression as MemberAccessExpressionSyntax;
var expressionIdentifier = expressionStart.Name as IdentifierNameSyntax;
if (expressionIdentifier == null || expressionIdentifier.Identifier.Text == null ||
expressionIdentifier.Identifier.Text != "RegisterSyntaxNodeAction")
from roslyn-analyzers.
1128 in MissingIdDeclarationAsync
Old:
currentRuleId = currentArg.Expression.ToString();
New:
var currentRuleIdentifier = currentArg.Expression as IdentifierNameSyntax;
currentRuleId = currentRuleIdentifier.Identifier.Text;
from roslyn-analyzers.
1311 in IdDeclTypeAsync
Old:
var newIdIdentifier = ruleIdSyntax.Identifier.ToString();
New:
var newIdIdentifier = ruleIdSyntax.Identifier.Text;
from roslyn-analyzers.
1263 in IdDeclTypeAsync
Old:
if (fieldDeclaration.Declaration.Type != null && fieldDeclaration.Declaration.Type.ToString() == "DiagnosticDescriptor")
New:
var fieldType = fieldDeclaration.Declaration.Type as IdentifierNameSyntax;
if (fieldType != null && fieldType.Identifier.Text == "DiagnosticDescriptor")
from roslyn-analyzers.
1450 in SupportedRulesAsync
Old:
var fieldType = fieldSyntax.Declaration.Type;
if (fieldType != null && fieldType.ToString() == "DiagnosticDescriptor")
New:
var fieldType = fieldSyntax.Declaration.Type as IdentifierNameSyntax;
if (fieldType != null && fieldType.Identifier.Text == "DiagnosticDescriptor")
from roslyn-analyzers.
2008 in GetFirstRuleName
Old:
if (rule != null && rule.Declaration.Type.ToString() == "DiagnosticDescriptor")
New:
var ruleType = rule.Declaration.Type as IdentifierNameSyntax;
if (rule != null && ruleType != null && ruleType.Identifier.Text == "DiagnosticDescriptor")
from roslyn-analyzers.
2186 in ExistingAnalysisMethod
Old:
var parameterType = parameters.First().Type;
if (parameterType != null && parameterType.ToString() == "SyntaxNodeAnalysisContext")
New:
var parameterType = parameters.First().Type as IdentifierNameSyntax;
if (parameterType != null && parameterType.Identifier.Text == "SyntaxNodeAnalysisContext")
from roslyn-analyzers.
Summary:
DiagnosticAnalyzer.cs: all instances of ToString() removed except:
- 2 instances on line 2191
if (returnSymbol.Type.ToString() != "System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.DiagnosticDescriptor>" && returnSymbol.Type.Kind.ToString() != "ErrorType")
CodeFixProvider.cs: all instances of ToString() removed
from roslyn-analyzers.
Related Issues (20)
- RS0042 incorrectly firing for ref usage HOT 5
- CA2213: False positive if base class Dispose is virtual HOT 3
- Performance problems in `DisposeObjectsBeforeLosingScope` HOT 1
- Microsoft.CodeAnalysis.PublicApiAnalyzers 3.3.4 does not work with .NET 8 projects HOT 1
- CA2000 false positive after upgrading to Visual Studio 2022 17.8 HOT 1
- CA1862 recommended for using string.Equals to perform case insensitive comparison but Entity Framework does not support it HOT 3
- CA2213 does not work well with WinForms/`Designer.cs` HOT 1
- CA1827 is not reported in an if statement HOT 1
- CA1848 false positive on `LoggerMessage` methods HOT 1
- CA1307 false-positive on Regex.Replace HOT 1
- CA1508: false positive HOT 1
- CA2021 false positive on Enumerable.OfType<T>extension HOT 2
- CA1305 false positives: `Convert.ToString(bool)`, `Convert.ToChar(string)`, `Convert.ToBoolean(strng)`
- ResxSourceGenerator should only generate code for the main file HOT 1
- Spurious CA2012 on lhs of pattern match
- Report RS1035 for XDocument.Save
- Move GlobalSuppressions.cs to Properties Folder
- Easier Bulk Fixing of warnings with One Click instead of Code Cleanup
- Improve SYSLIB1051 by marking the fields that are incompatible with LibraryImport
- CA1508 false positive in declaration pattern
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roslyn-analyzers.