Giter Club home page Giter Club logo

Comments (10)

daking2014 avatar daking2014 commented on June 5, 2024

8

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

598 in MissingAnalysisMethodAsync

Old:

string methodName = invocationExpression.ArgumentList.Arguments[0].ToString();

New:

var methodIdentifier = invocationExpression.ArgumentList.Arguments[0].Expression as IdentifierNameSyntax;
string methodName = methodIdentifier.Identifier.Text;

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

1069 in MultipleStatementsAsync

Old:

var expressionStart = expression.Expression as MemberAccessExpressionSyntax;
if (expressionStart == null || expressionStart.Name == null ||
                    expressionStart.Name.ToString() != "RegisterSyntaxNodeAction")

New:

var expressionStart = expression.Expression as MemberAccessExpressionSyntax;
var expressionIdentifier = expressionStart.Name as IdentifierNameSyntax;
if (expressionIdentifier == null || expressionIdentifier.Identifier.Text == null ||
                    expressionIdentifier.Identifier.Text != "RegisterSyntaxNodeAction")

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

1128 in MissingIdDeclarationAsync

Old:

currentRuleId = currentArg.Expression.ToString();

New:

var currentRuleIdentifier = currentArg.Expression as IdentifierNameSyntax;
currentRuleId = currentRuleIdentifier.Identifier.Text;

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

1311 in IdDeclTypeAsync

Old:

var newIdIdentifier = ruleIdSyntax.Identifier.ToString();

New:

var newIdIdentifier = ruleIdSyntax.Identifier.Text;

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

1263 in IdDeclTypeAsync

Old:

if (fieldDeclaration.Declaration.Type != null && fieldDeclaration.Declaration.Type.ToString() == "DiagnosticDescriptor")

New:

var fieldType = fieldDeclaration.Declaration.Type as IdentifierNameSyntax;
if (fieldType != null && fieldType.Identifier.Text == "DiagnosticDescriptor")

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

1450 in SupportedRulesAsync

Old:

var fieldType = fieldSyntax.Declaration.Type;
if (fieldType != null && fieldType.ToString() == "DiagnosticDescriptor")

New:

var fieldType = fieldSyntax.Declaration.Type as IdentifierNameSyntax;
if (fieldType != null && fieldType.Identifier.Text == "DiagnosticDescriptor")

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

2008 in GetFirstRuleName

Old:

if (rule != null && rule.Declaration.Type.ToString() == "DiagnosticDescriptor")

New:

var ruleType = rule.Declaration.Type as IdentifierNameSyntax;
if (rule != null && ruleType != null && ruleType.Identifier.Text == "DiagnosticDescriptor")

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

2186 in ExistingAnalysisMethod

Old:

var parameterType = parameters.First().Type;
if (parameterType != null && parameterType.ToString() == "SyntaxNodeAnalysisContext")

New:

var parameterType = parameters.First().Type as IdentifierNameSyntax;
if (parameterType != null && parameterType.Identifier.Text == "SyntaxNodeAnalysisContext")

from roslyn-analyzers.

zoepetard avatar zoepetard commented on June 5, 2024

Summary:
DiagnosticAnalyzer.cs: all instances of ToString() removed except:

  • 2 instances on line 2191
 if (returnSymbol.Type.ToString() != "System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.DiagnosticDescriptor>" && returnSymbol.Type.Kind.ToString() != "ErrorType")

CodeFixProvider.cs: all instances of ToString() removed

from roslyn-analyzers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.