Perf: Roslyn NRE at `Microsoft.CodeAnalysis.SyntaxNode.get_HasErrors` about performance HOT 5 OPEN

@RikkiGibson PTAL

from performance.

This is like not a wasm-specific issue. Who can we ping for this?

from performance.

@jaredpar Might be a good place to start.

from performance.

Where can I find more diagnostic information about the failure? For example, which benchmark was running, and how to run it locally to reproduce the issue. I wasn't able to find the stack trace from the issue description in the linked build.

The method exhibiting the NRE is found here

https://github.com/dotnet/roslyn/blob/6338d838e611f4e72760720b34d132cba325b5dd/src/Compilers/Core/Portable/Syntax/SyntaxNode.cs#L1622-L1633

        internal bool HasErrors
        {
            get
            {
                if (!this.ContainsDiagnostics)
                {
                    return false;
                }

                return HasErrorsSlow();
            }
        }

Maybe the stack trace is missing info about which call within this property we were executing when the NRE occurred.

from performance.

Here is a link to the full log for that run, https://pvscmdupload.blob.core.windows.net/drewtest/NRELog.txt. It was not during the execution of any benchmark, but instead during the compilation of our Benchmark.Extensions project. This mostly contains settings and helpers for BDN.

Also, here is the link for the payload of the run, https://pvscmdupload.blob.core.windows.net/drewtest/NREPayload.zip. This contains the built framework, and WASM runtime packs that were in use during the run.

from performance.