Giter Club home page Giter Club logo

Comments (12)

github-actions avatar github-actions commented on June 21, 2024 2

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

from maui.

jfversluis avatar jfversluis commented on June 21, 2024 1

@muffadal53 actually it's the other way around, I was mistaken. The ListView sets the IsRefreshing for you. So what happens is that the ListView sets IsRefreshing to true before it gets to this check: https://github.com/muffadal53/ListViewRefreshApp/blob/master/ViewModel/TestConfigViewModel.cs#L33

That check will evaluate to being false and then entire thing is being skipped and IsRefreshed is never set to false.

This is not a bug in .NET MAUI but rather something that is not correct in your code.

Thanks for the report!

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024 1

@samhouts: This issue is not resolved.So, can you please reopen this issue.Thanks.

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024 1

It is really surprising that without providing working solution or workaround MAUI issues are just getting closed. Please provide answer to this issue @jfversluis, @davidortinau, @samhouts.

from maui.

ninachen03 avatar ninachen03 commented on June 21, 2024

Verified this issue with Visual Studio 17.10 Preview 7 (8.0.40 & 8.0.3). Can repro it.

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024

@jfversluis: Can you please help in fixing this issue with workaround or urgent service pack release of .NET 8.0 as it is common usecase to use PullToRefresh functionality of ListView and it is urgent for our app release?

from maui.

eynerdevp avatar eynerdevp commented on June 21, 2024

same error here

from maui.

jfversluis avatar jfversluis commented on June 21, 2024

Is there any reason you're setting Mode=OneWay on the IsRefreshing property? I think that might be the issue here. The ListView will set that to false whenever it's done refreshing, but now it can't because you set the mode to OneWay? Have you tried that?

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024

Is there any reason you're setting Mode=OneWay on the IsRefreshing property? I think that might be the issue here. The ListView will set that to false whenever it's done refreshing, but now it can't because you set the mode to OneWay? Have you tried that?

@jfversluis: The reason I have set the Mode=OneWay is because I am managing the value of IsRefreshing from the ViewModel during Reload operation. And even if you remove the Mode=OneWay the IsRefreshing spinner remains stuck
And if you look at the documentation of MAUI it is contradicting to what you have mentioned in your comment and here is what it is says in the documentation "Once the ListView is refreshed, the IsRefreshing property should be set to false, or the EndRefresh method should be called on the ListView, to indicate that the refresh is complete."

So, please let me know how this issue can be Awaiting prompt reply.

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024

@jfversluis: Yes it is other way round. The "IsRefreshing" is set to true by the ListView and we need to set it to "false" after Refresh. And I have updated my code and below is the updated version. Now, the "IsRefreshed" is set to false but even with that change the "IsRefreshing" spinner doesn't get closed.

Below us the updated code in the ViewModel:

`private void RefreshListItems()
{
try
{
TestConfigList.Clear();
ReloadFromSource();
}
finally
{
ListRefreshing = false;
}

}`

You can check the repositry too:
https://github.com/muffadal53/ListViewRefreshApp/blob/master/ViewModel/TestConfigViewModel.cs#L33

So, without checking the code by making the change you are suggesting as not an issue you just closed the issue by giving the reference of the MAUI document. This doesn't seem to be right. And it is not only me who has got this issue. Along with me @ninachen03 and @eynerdevp also are able to reproduce the issue. So, please use my updated version of the ListView sample and run it on your side and let me know the behavior.

@davidortinau: Please look into this issue and let me know the solution as it is urgent on our side.

Awaiting feedback at the earliest. And this issue is not Closed till the solution is provided.

Regards

from maui.

jfversluis avatar jfversluis commented on June 21, 2024

I pulled down your code again and added OnPropertyChanged(nameof(ListRefreshing)); right after you set ListRefreshing = false;. This makes it work as it should.

There is no issue with .NET MAUI, this works as intended, therefore it's closed. The issue is somewhere in the logic in your code unfortunately.

from maui.

muffadal53 avatar muffadal53 commented on June 21, 2024

Thanks @jfversluis for the clarification. I think it would be better to have a concrete example in MAUI documentation of ListView showing in section of https://learn.microsoft.com/en-us/dotnet/maui/user-interface/controls/listview?view=net-maui-8.0#pull-to-refresh Pull to refresh on how this property must be handled. The current example doesn't seem to explain this detail properly.

from maui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.