Comments (8)
We could add something to eng/common/
The other drawback to that approach is that repos don't get to decide where in the folder hierarchy the file needs to live. So in order for the script to be found, the calling scripts need to know where the $RepoRoot
is - so they can find $RepoRoot/eng/common
. There also may be files (like CMake files) that depend on being in a specific location in the folder structure.
IMO - the system should be built in such a way that files can be placed anywhere in the repo, and still be kept in sync with the 'master' script.
from arcade.
We need to make sure this change to symbol stripping gets in here: https://github.com/dotnet/core-setup/issues/1607. (Keeping unstripped binaries around even if symbol stripping is enabled, for certain scenarios where later tooling expects to do the stripping itself.)
from arcade.
A bit related to #53. We could add something to eng/common/
. Drawback of this approach is that repos that don't need these files will end up with them in their repos anyway, probably not a big deal if the benefit is big
from arcade.
Maybe consider if this fits in with #774, dependency expression extensibility. That is, make the scripts a dependency repos can add if they need them, and express anywhere they want.
from arcade.
Yes I agree this should be extensible and repo's should be able to opt-in to particular folders and their locations. I was chatting with @mmitche about something similar for version updates but I think the same should hold true for file updates. Repo's can easily configure this in their Version.details.xml file.
from arcade.
Yeah that's what I'm thinking. I think we need more generic dependency expression, let me see what I can come up with.
from arcade.
@mmitche what do you want to do with this one?
from arcade.
I think we can close it. Most of the native code has been consolidated into runtime, so there is much less copying around now.
from arcade.
Related Issues (20)
- RefSource generator generates setter instead of `init`
- Bump the version of Drop.App
- [dnceng-bot] Branch `release/8.0` can't be merged to Azure DevOps internal branch HOT 3
- [dnceng-bot] Branch https://github.com/pavelsavara/runtime/commits/release/8.0/ can't be merged to Azure DevOps internal branch HOT 1
- Restoring .NET workloads when using .NET Arcade HOT 5
- Issue restoring the project: Microsoft.DotNet.Arcade.Sdk not found HOT 3
- Revert SYSLIB0057 suppression once arcade consumes 9.0-preview7 SDK
- dotnet-install.sh fails when dot-sourced from the command line
- dotnet-install.sh uses the wrong name when dot-sourced HOT 10
- Feature request: dotnet-install script option to print out the path it installed to
- The sign type is set to 'real' even if the `_SignType` variable is defined HOT 4
- Version of Microsoft.DotNet.Arcade.Sdk to use for MSBuild HOT 10
- SignTool should not attempt to sign 0 length files
- Enable NuGet Audit in .NET repositories HOT 11
- Arcade MSBuild task packages shouldn't carry assemblies with it that are available inbox in VS / .NET SDK's msbuild HOT 1
- Upgrade STJ to 8.0.4 in desktop msbuild tasks and remove NuGetAudit suppression
- Align SignTool MSBuild Usage on Windows with Current Execution Environment HOT 2
- Update release version to 10.0 in generate-sbom.yml
- RestApiException`1: The response contained an invalid status code 500 Internal Server Error HOT 1
- Unpack/repack support for signtool for Wix5 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arcade.