Comments (6)
Thank you @streeve for your quick review. All the points you mentioned have been taken into consideration.
Just to mention, the unit test are not that easy to implement on MATLAB. As far as I know, Code Ocean is the easiest way to provide offline test for reproducibility. The link to the related Capsule has been added in README.md
.
Considering the API docs, I am not sure to understand its meaning in the MATLAB scripting context. All functions and methods are provided along with help sections (in addition to documentation). For instance, juste type
help gmshGeo
to get help about the gmshGeo
constructor.
from mtex2gmsh.
Great, thanks
The Code Ocean online environment is quite nice. My only objection is that (as far as I can tell) it only tests one case. Something like https://github.com/vitorsr/SIHR/blob/master/utils/automated_testing.m could work
from mtex2gmsh.
For the API docs, a section just mentioning both help
(thank you, I haven't actively used matlab in a while) and methods
to make it easy to explore all options in the class
from mtex2gmsh.
I have added a file named unitTest. It sums up all the examples given in the eponymous folder, plus it plots the geometry in each case.
from mtex2gmsh.
Alternatively, I have update the code on code Ocean, following your recommendations (that is, provide multiple examples).
Tell me if if need to keep the aforementioned unitTest.m
or/and the reference to the capsule.
from mtex2gmsh.
I think unitTest.m
is exactly what you want: it runs the main examples, is easy to extend, and you can run on Code Ocean or locally
from mtex2gmsh.
Related Issues (18)
- [need some help] mesh-command fails HOT 2
- issues with MTEX2Prisms HOT 7
- Image meshing HOT 1
- how to plot the output from Quadrature file. HOT 3
- Create edges between nodes in Z direction HOT 1
- Create more elements in Z direction HOT 6
- [need some help] gmshGeo fails HOT 3
- Running MTEX2Gmsh on macOS Ventura 13.3.1 HOT 8
- Gradient option does not work in 2D
- medium with an ODF reflecting the bulk texture HOT 7
- matlab warnings HOT 3
- Paper revisions HOT 2
- Paper review HOT 5
- Incoherent Elements at grain boundaries HOT 10
- [help wanted] Creating phase groups HOT 1
- Physical Surface when meshing in 2D HOT 3
- Add a 'medium' contour to a 2D mesh HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mtex2gmsh.