Giter Club home page Giter Club logo

Comments (6)

DorianDepriester avatar DorianDepriester commented on June 3, 2024

Thank you @streeve for your quick review. All the points you mentioned have been taken into consideration.

Just to mention, the unit test are not that easy to implement on MATLAB. As far as I know, Code Ocean is the easiest way to provide offline test for reproducibility. The link to the related Capsule has been added in README.md.

Considering the API docs, I am not sure to understand its meaning in the MATLAB scripting context. All functions and methods are provided along with help sections (in addition to documentation). For instance, juste type

help gmshGeo

to get help about the gmshGeo constructor.

from mtex2gmsh.

streeve avatar streeve commented on June 3, 2024

Great, thanks

The Code Ocean online environment is quite nice. My only objection is that (as far as I can tell) it only tests one case. Something like https://github.com/vitorsr/SIHR/blob/master/utils/automated_testing.m could work

from mtex2gmsh.

streeve avatar streeve commented on June 3, 2024

For the API docs, a section just mentioning both help (thank you, I haven't actively used matlab in a while) and methods to make it easy to explore all options in the class

from mtex2gmsh.

DorianDepriester avatar DorianDepriester commented on June 3, 2024

I have added a file named unitTest. It sums up all the examples given in the eponymous folder, plus it plots the geometry in each case.

from mtex2gmsh.

DorianDepriester avatar DorianDepriester commented on June 3, 2024

Alternatively, I have update the code on code Ocean, following your recommendations (that is, provide multiple examples).

Tell me if if need to keep the aforementioned unitTest.m or/and the reference to the capsule.

from mtex2gmsh.

streeve avatar streeve commented on June 3, 2024

I think unitTest.m is exactly what you want: it runs the main examples, is easy to extend, and you can run on Code Ocean or locally

from mtex2gmsh.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.