Giter Club home page Giter Club logo

Comments (3)

dop251 avatar dop251 commented on August 15, 2024

InterruptedError is sort of meant to be treated differently, because it's not really an error. Could you please illustrate with some code?

from goja.

slavikm avatar slavikm commented on August 15, 2024
	vm := goja.New()
	vm.Set("console", map[string]interface{}{"log": js.ConsoleLog(scriptName)})
	timer := time.AfterFunc(timeout, func() {
		defer util.RecoverWithStack()
		vm.Interrupt(fmt.Errorf("script %s timeout after %d", scriptName, timeout))
	})
	defer timer.Stop()
	res, err = vm.RunScript(scriptName, script)
	if err != nil {
		if ierr, ok := err.(*goja.InterruptedError); ok {
			log.Errorf("JS error: %v ", ierr.Value())
		} else {
			log.Errorf("JS error: %v", err)
		}
		return
	}

So, instead of just logging the issue, I need to check the type of error and then log it. Otherwise, I'm getting <nil> in the error instead of the timeout error.

from goja.

dop251 avatar dop251 commented on August 15, 2024

Ok, raise a PR.

from goja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.