Clean Code about flutter_calendar_carousel HOT 8 CLOSED

@hyochan @KnockaertSven I think it should be lowercase d weekdays not weekDays, would you agree? I can fix that on PR #77

from flutter_calendar_carousel.

@hyochan Yes that's right. I'm still doing some work on it I can close this issue later on.

from flutter_calendar_carousel.

This is really minor so I figured I'd put it here:
-> weekdayTextStyle is written with a lowercase d

-> the other weekday props are written with a capital D , e.g. :
• showWeekDays
• weekDayMargin
• etc

I realise this may be nitpicking, but it'd be nice if it would be streamlined :)

from flutter_calendar_carousel.

@edTheGuy00 This is absolutely great decision to go for refactoring. Everyone will appreciate your work. 👊

from flutter_calendar_carousel.

@edTheGuy00 I've merged your PR. However, I won't close this issue yet because there seems 2 more to go from your statements.

• Separate Header, No Header
• Separate MonthView and WeekView

from flutter_calendar_carousel.

@KnockaertSven sure I'll take a look at this

from flutter_calendar_carousel.

@edTheGuy00 Agree.

from flutter_calendar_carousel.

This issue is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days.

from flutter_calendar_carousel.