At the moment, to get and set configuration values, users have to create a <code class

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

`timetrace config` command about timetrace HOT 7 OPEN

dominikbraun commented on May 30, 2024 1

`timetrace config` command

from timetrace.

Comments (7)

Eddie023 commented on May 30, 2024 1

Hi @dominikbraun, I would like to work on this issue.

from timetrace.

dominikbraun commented on May 30, 2024 1

@Eddie023 Your approach is fine, but you don't even need to introduce a new userConfig file because there already is support for config.yaml:

timetrace/config/config.go

Lines 16 to 48 in 2ba16af

 // FromFile reads a configuration file called config.yml and returns it as a 

 // Config instance. If no configuration file is found, nil and no error will be 

 // returned. The configuration must live in one of the following directories: 

 // 

 // - /etc/timetrace 

 // - $HOME/.timetrace 

 // - . 

 // 

 // In case multiple configuration files are found, the one in the most specific 

 // or "closest" directory will be preferred. 

 func FromFile() (*Config, error) { 

 viper.SetConfigName("config") 

 viper.SetConfigType("yaml") 

 viper.AddConfigPath("/etc/timetrace/") 

 viper.AddConfigPath("$HOME/.timetrace") 

 viper.AddConfigPath(".") 

 if err := viper.ReadInConfig(); err != nil { 

 if _, ok := err.(viper.ConfigFileNotFoundError); !ok { 

 return nil, err 

 } 

 } 

 var config Config 

 if err := viper.Unmarshal(&config); err != nil { 

 return nil, err 

 } 

 cached = &config 

 return cached, nil 

 }

Shouldn't we give them the list of possible configurable keys? Something like timetrace config list which will return all the configurable keys and the current value. Let me know what you think. I am confused what are the configurable things currently available.

Yes. I think that this could even be done using timetrace config get without an argument. You could simply display all fields of config.Config to do so. BTW, you can get the already parsed configuration using the Timetrace.Config() function.

from timetrace.

Eddie023 commented on May 30, 2024 1

@dominikbraun Sorry got caught up with work so working only on the weekends. I will send you draft PR by this weekend and you can decide what to do.

from timetrace.

dominikbraun commented on May 30, 2024 1

No problem, thanks for the update! 👍

from timetrace.

Eddie023 commented on May 30, 2024

@dominikbraun Few questions regarding this issue. Here is my approach of solving this issue. let me know what you think.

Create a userConfig file in config/ dir and upon each timetrace config set <KEY> <VALUE> command upsert the KEY VALUE.
If the userConfig file is available then add some functionality like merge-deep-left to override withuserConfig list.

Question:

Shouldn't we give them the list of possible configurable keys? Something like timetrace config list which will return all the configurable keys and the current value. Let me know what you think. I am confused what are the configurable things currently available.

from timetrace.

dominikbraun commented on May 30, 2024

Hi @Eddie023! Any updates on this one? If you don't have the capacities to do this issue at the moment, just let me know.

from timetrace.

Eddie023 commented on May 30, 2024

@dominikbraun Sorry that I wasn't able to do this issue this weekend as well. Had some personal work pulling me. I don't want to extend this issue any longer so I will just unassign myself. Again, sorry for not getting this issue through.

from timetrace.

`timetrace config` command about timetrace HOT 7 OPEN

Comments (7)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// FromFile reads a configuration file called config.yml and returns it as a
	// Config instance. If no configuration file is found, nil and no error will be
	// returned. The configuration must live in one of the following directories:
	//
	// - /etc/timetrace
	// - $HOME/.timetrace
	// - .
	//
	// In case multiple configuration files are found, the one in the most specific
	// or "closest" directory will be preferred.
	func FromFile() (*Config, error) {
	viper.SetConfigName("config")
	viper.SetConfigType("yaml")
	viper.AddConfigPath("/etc/timetrace/")
	viper.AddConfigPath("$HOME/.timetrace")
	viper.AddConfigPath(".")

	if err := viper.ReadInConfig(); err != nil {
	if _, ok := err.(viper.ConfigFileNotFoundError); !ok {
	return nil, err
	}
	}

	var config Config

	if err := viper.Unmarshal(&config); err != nil {
	return nil, err
	}

	cached = &config

	return cached, nil
	}