Giter Club home page Giter Club logo

Comments (4)

seansfkelley avatar seansfkelley commented on August 22, 2024

As, obviously, this code could never return false. You could replace the entire implementation with return true and it would behave the same way.

Not quite:

> NaN === NaN
false

Which I think is the intent, in which case it would perhaps be clearer for this function to be implemented as return !isNaN(obj - 0); or perhaps return !isNaN(+obj);.

from humps.

billinghamj avatar billinghamj commented on August 22, 2024

Ah yes I guess that could be it. Definitely should be using the explicit function for that - perhaps the Number.isNaN one though.

from humps.

billinghamj avatar billinghamj commented on August 22, 2024

Yep, there we go: #13 (diff)

Looks like that review comment was not addressed.

from humps.

billinghamj avatar billinghamj commented on August 22, 2024

Closing due to inactivity

from humps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.