Giter Club home page Giter Club logo

Comments (12)

matthewmcvickar avatar matthewmcvickar commented on July 23, 2024 2

@yowainwright Wooo!! Thank you so much! That test Codepen looks good to me. Can we call this issue closed, or is #100 the same bug?

from stickybits.

matthewmcvickar avatar matthewmcvickar commented on July 23, 2024 1

@yowainwright Thank you for the update; I totally understand this is extra work for you. Can’t thank you enough! I’m using this on a few client projects and I'm eager for the update. :)

from stickybits.

yowainwright avatar yowainwright commented on July 23, 2024

@matthewmcvickar first, thank you for the clear question/issue! πŸ™

This issue is that because the sticky element is not the first child of its parent element, the useStickyClasses option doesn't calculate correctly. This will be fixed asap.

from stickybits.

kvanbere avatar kvanbere commented on July 23, 2024

I believe it is a requirement with native sticky for the element to be the first child in the parent .. if not I have problems under Firefox and likewise native bottom stickys wouldn't work for me unless they were the last element

from stickybits.

matthewmcvickar avatar matthewmcvickar commented on July 23, 2024

@yowainwright Aha, that is the problem! If I just put a wrapper around the whole page so that the toolbar is the first element, it works just fine. I'll use that as a workaround for the time being.

@kvanberendonck Hmm, I'm not seeing that. Here's a Codepen demo of non-first-children working just fine with native position: sticky. Works fine for me in Chrome, Safari, and Firefox. https://codepen.io/matthewmcvickar/pen/ayWrWO

from stickybits.

kvanbere avatar kvanbere commented on July 23, 2024

For example element 3 in this fork doesn't work as expected even under Chrome unless it's the last element, top stickys seem to be working fine.

https://codepen.io/anon/pen/rzmgKa

from stickybits.

matthewmcvickar avatar matthewmcvickar commented on July 23, 2024

@kvanberendonck Ah, I see what you mean now. And as you can see in this fork, there can be multiple bottom stickys as long as they are the last elements in their parent and aren't interrupted by a non-sticky element.

from stickybits.

matthewmcvickar avatar matthewmcvickar commented on July 23, 2024

@yowainwright Do you have an estimate for when v2 will be released?

from stickybits.

yowainwright avatar yowainwright commented on July 23, 2024

@matthewmcvickar Hopefully within the week. I apologize. The time-lapse is not intentional.

from stickybits.

yowainwright avatar yowainwright commented on July 23, 2024

@matthewmcvickar I updated the original Codepen here. I changed the order of the dom. https://codepen.io/yowainwright/pen/rGwqee

Stickybits 2.0 was just pushed. πŸ™

Sorry for the wait. Let me know how I can help. ~Thanks

from stickybits.

paolomoretti avatar paolomoretti commented on July 23, 2024

+1

from stickybits.

yowainwright avatar yowainwright commented on July 23, 2024

@matthewmcvickar thanks for following up!

from stickybits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.