Giter Club home page Giter Club logo

Comments (8)

josegonzalez avatar josegonzalez commented on July 30, 2024

Can you not make the dropwizard app use the single DATABASE_URL env var for connecting to the instance?

from dokku-postgres.

andersem avatar andersem commented on July 30, 2024

It can probably be done, but by what I can see it would be a hack (DW doesn't seem too flexible here), and I thought maybe it would be more correct to do it in the plugin.

Would it be wrong to expose them here, my thought was that offering more flexibility for using the plugin would be good?

from dokku-postgres.

josegonzalez avatar josegonzalez commented on July 30, 2024

I'm personally against this - we're actually trying to get our developers at work to standardize on _URL to reduce the env vars we set for applications - but I defer to @Flink here. Thoughts?

from dokku-postgres.

andersem avatar andersem commented on July 30, 2024

I understand it might be a philosophical question, and you don't want a
variable for every possible use case. I'll leave the decision to you guys.

tir. 22. sep. 2015, 06.09 skrev Jose Diaz-Gonzalez <[email protected]

:

I'm personally against this - we're actually trying to get our developers
at work to standardize on _URL to reduce the env vars we set for
applications - but I defer to @Flink https://github.com/Flink here.
Thoughts?


Reply to this email directly or view it on GitHub
#22 (comment)
.

from dokku-postgres.

Flink avatar Flink commented on July 30, 2024

Yes I agree with @josegonzalez, those variables aren’t standards I think. If another app needs, say, DB_HOST or DB_PASS or DATABASE_PASS, what do we do? We add them also?
The DATABASE_URL scheme is something widespread for some years now, thanks to Heroku mainly I think. By the way, Heroku won’t give you anything else than the DATABASE_URL var.

Technically, all the needed information is present in this variable and modern applications should be able to use that.

Another thing you can do, is to declare those variables with dokku config:set like you’d do on Heroku. One thing that can be annoying is if the IP of the container changes but we can (and should I think) do something for that (by using an alias used in --link option). We should also think about exporting the DATABASE_URL with dokku config:set so it will be available like any other env var (and like on Heroku one more time ;)).

from dokku-postgres.

andersem avatar andersem commented on July 30, 2024

Ok, I understand. I'll try config:set, then :)

from dokku-postgres.

josegonzalez avatar josegonzalez commented on July 30, 2024

We set the DATABASE_URL via a docker-arg so it disappears when the container is not linked. Much easier than dealing with "omg you unset my config" problems.

from dokku-postgres.

Flink avatar Flink commented on July 30, 2024

yeah but also it is not exposed in the app config, so it’s not easily available. We should have a behavior similar to Heroku on this one. I’m working on it, we’ll see :)

from dokku-postgres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.