Giter Club home page Giter Club logo

Comments (3)

kitsonk avatar kitsonk commented on July 22, 2024

This is not the API. Though it works in certain cases based on they way the code is working, it was never intended that publish() would support multiple events. It would be unsafe to add that signature because people would then rely upon unintended behaviour of the code. This is one of the good things in TypeScript is we can enforce the intent of the code.

From a code perspective, publish() uses Evented.emit() which uses on.emit() which in turn uses an internal function called syntheticDispatch() when it is not a DOM target, which does pass whatever arguments, but only under certain conditions.

Thanks for the feedback though.

from typings.

nickp10 avatar nickp10 commented on July 22, 2024

According to the API documentation:

All arguments after the first will be passed to the subscribers, so any number of arguments can be provided (not just event).

I would assume the TypeScript definitions would need to represent what the API documentation is stating.

from typings.

kitsonk avatar kitsonk commented on July 22, 2024

Yes I see that is in the source comments and there is a test for it as well, so even though the chain is rather "fragile" in my opinion of how it was delivered, it was clearly intentional.

from typings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.