Giter Club home page Giter Club logo

Comments (4)

anandthakker avatar anandthakker commented on May 21, 2024

@tmcw How would you feel about this option accepting a glob for the whitelist?

(edit) That would allow a direct whitelist and wildcard matching, but also traversing deeper into the dependencies. E.g.: --external turf-*, --external !(through2|request), --external */node_modules/*

from documentation.

tmcw avatar tmcw commented on May 21, 2024

👍 for the node-facing api, we could use something like micromatch or minimatch to augment the existing external modules check. That said, I'm really not sure whether globs written as cli arguments are always expanded, so not sure if it'll work on both levels.

from documentation.

anandthakker avatar anandthakker commented on May 21, 2024

Oh, good point about the cli expansion... Although, since it probably makes sense to treat the first node_modules/ as understood (so that I could say --external turf-* instead of --external node_modules/turf*), I think the globs that a user passed in on the command line would actually fail to match the real directories and thus just be passed in as strings.

Hoping to put in a PR for this soon.

from documentation.

tmcw avatar tmcw commented on May 21, 2024

👍 fixed in #60

from documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.