Giter Club home page Giter Club logo

Comments (20)

scuben avatar scuben commented on July 28, 2024 1

Can any of you try #79 ? I added some instructions for you in the top message. Also, please give your version of php, for science.

Your PR works on 7.2.19 too. Thank you!

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024 1

Thank you for reporting and testing! Expect a release tomorrow morning!

from persistence.

scuben avatar scuben commented on July 28, 2024 1

For me: 1.3.1 works now on both PHP versions.

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Can you manually add interface_exists(\Doctrine\Common\Persistence\Mapping\ClassMetadata::class); at the end of Doctrine\Persistence\Mapping\Driver\MappingDriver and report back?

from persistence.

scuben avatar scuben commented on July 28, 2024

I just ran into the same issue, but on SF 3.4.
I do not have the issue on latest PHP 7.2.25 but do have the issue on 7.2.19.

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Can any of you try #79 ? I added some instructions for you in the top message. Also, please give your version of php, for science.

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

I do not have the issue on latest PHP 7.2.25 but do have the issue on 7.2.19.

Ah great, thanks for reporting this!

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Anyone experiencing this, please report what php version you use if it's a 7.2 one and higher than 7.2.19, or if it's not a 7.2 one.

from persistence.

wokenlex avatar wokenlex commented on July 28, 2024

Anyone experiencing this, please report what php version you use if it's a 7.2 one and higher than 7.2.19, or if it's not a 7.2 one.

OSX:
$ php -v
PHP 7.2.25

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Oh wow that's weird, @scuben said it worked on his machine with that version. Are you sure you are not using another version (with virtualization, maybe)?

from persistence.

alcaeus avatar alcaeus commented on July 28, 2024

1.3.1 has been released. Please open a new issue if you encounter problems.

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

I can't reproduce this on the official 7.2.19-cli Docker image. I'd love to get more details, I've tried the following minimal script:

<?php

require 'vendor/autoload.php';

use Doctrine\ORM\Mapping\Driver\XmlDriver;

new XmlDriver;

@scuben can you try the script above on your machine with 7.2.19 and tell us if it crashes with the error above or not? And if not, can you please try giving a minimal reproducer that does not involve composer, but just a simple php script like above? I'm trying to understand under what conditions this happens.

from persistence.

scuben avatar scuben commented on July 28, 2024

@greg0ire Any chance you did misread my comment and switched "now" to "not"? :)

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

No, I fully understand, the thing is, I'd like to revert my fix and replace it with some Composer constraints like php: ^7.2.21. The things is, I don't don't know which versions of php have the issue, so I tried reproducing the bug on 7.2.19 by using Docker, but couldn't.

from persistence.

scuben avatar scuben commented on July 28, 2024

You might try it with symfony/composer as it happened on cache:clear after composer install for me. I can't create a script to reproduce the bug too because I just have limited time these days and not much knowledge to use orm or persitence separately and not within a symfony context.

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

The script I wrote above can be tried within a symfony context. You can name it crash.php, put it at the root of your project and run it with php crash.php. Can you please try that? πŸ™

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Good news I reproduced the bug thanks to this comment (I would thank stof but I think he has enough notifications as is, so if you come across this issue, stof, thanks again <3)

Here is the code:

<?php

require 'vendor/autoload.php';

use Doctrine\ORM\Mapping\Driver\XmlDriver;
use Doctrine\Persistence\Mapping\Driver\FileDriver;

class_exists(FileDriver::class);
class_exists(XmlDriver::class);

I just have to do a bisection now :)

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

Well, I do have the bug for 7.2.25 too… I guess when you upgraded, it changed the order in which the classes were loaded for some obscure reason @scuben

from persistence.

greg0ire avatar greg0ire commented on July 28, 2024

7.3.12 has the crash too, but 7.4.0 does not.

from persistence.

scuben avatar scuben commented on July 28, 2024

Glad you could reproduce. It must somehow be connected with a composer install on my side.

from persistence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.