It's really easy to hurt yourself about python-gitlab3 HOT 6 CLOSED

That specific example's a definite bug due to my lazily coded delete_member() function. I'll issue a fix for it soon. Update functions may have a similar issue...

"Perhaps doing a test for object type before executing anything and provide a meaningful exception."
For similar cases, I'll probably add something like this.

Part of the problem stems from confusion of having multiple types of users/members. It's not something I like, but I don't know how to avoid given the current GitLab API. Adding some type checking here and there like you suggested may work well enough. I'm open to any other ideas though.

Thanks for the feedback!

from python-gitlab3.

What would have been the proper way to delete a member from a group?

from python-gitlab3.

Due in part to the crippled group membership API (no get or update) and the inflexibility of group.delete_member(), there's only one awkward way to do it and that's to use a Member object returned from a call to group.members(). This is obviously a problem, heh. I'll see about allowing delete_member/delete_user/etc. to accept any type of user or member object.

*edit: Just realized you can also use group.find_member() and pass the result to group.delete_member() (or call delete() on the result). This still isn't ideal though since find_member() will potentially have to query the entire list of members to return a single one.

from python-gitlab3.

Perhaps modify this function so that when a sub_api is added you set a value, parent_api, in the Class. Then when certain functions are called (e.g. delete()) it checks that the object being passed matches the type (e.g. type User) and that parent_api is set to the current Class type self. This way only children objects can be passed as an argument and if a global User object is passed parent_api will either == to None or to GitLab depending on how you want to set it up.

from python-gitlab3.

Committed a workaround for now to ensure the type is correct, but ideally I'd like to make it more flexible and, e.g. allow a gitlab3.User object be passed to gitlab3.Group.delete_member().

from python-gitlab3.

I'm closing this bug report as new issues should be reported for delete problems and api protections.

from python-gitlab3.