Split design time support to a separate assembly about dockpanelsuite HOT 8 CLOSED

Is System.Design truly required in the first place? It appears the only usage is in the DockPanel for the Designer attribute, however we're not actually setting a custom designer.

from dockpanelsuite.

I never use the Designer due to its limitations.

from dockpanelsuite.

Is there any side effect if we remove [Designer(typeof(System.Windows.Forms.Design.ControlDesigner))] from DockPanel definition?

If no side effect, we might remove System.Design completely.

from dockpanelsuite.

I believe the purpose is to prevent controls from being parented by the dockpanel via the designer. For example, currently if you drop a control on top of a dockpanel it will not be added to the dockpanel's controls. The designer attribute is overriding the PanelDesigner set on the base class, which will allow you to drop a control onto the dockpanel itself (as you could with any panel).

So the purpose of the designer attribute here is desired, although I wonder if it can be accomplished another way.

from dockpanelsuite.

If that's the usage of that attribute we can change it from using typeof to using a string.

from dockpanelsuite.

Ah yes, good call. That should work perfectly!

from dockpanelsuite.

According to this page, we should be able to replace [Designer(typeof(System.Windows.Forms.Design.ControlDesigner))] with [Designer("System.Windows.Forms.Design.ControlDesigner, System.Design"))] and then remove System.Design from reference list,

http://archive.msdn.microsoft.com/WinFormsCustomCtrl

Can you test it? @roken

from dockpanelsuite.

Looks good, you can check that in.

from dockpanelsuite.