Giter Club home page Giter Club logo

Comments (12)

crazy-max avatar crazy-max commented on May 31, 2024 2

@gdubicki @tillsteinbach You can test the type=pep440 with crazy-max/docker-metadata-action@pep440. Doc: https://github.com/crazy-max/docker-metadata-action/tree/pep440#typepep440

from metadata-action.

tillsteinbach avatar tillsteinbach commented on May 31, 2024 1

Ahrg! Yes, I was unconcentrated :) really nice work!
Interestingly I did not notice my mistake because PyPi did the same correction to my version number :D

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@gdubicki Thanks for your feedback. I think we could add a new type=pep440 or even translate to semver if possible. Will think about that.

from metadata-action.

tillsteinbach avatar tillsteinbach commented on May 31, 2024

I have the same request! Would really appreciate having pep440 support! For now I work with sermver + raw for prereleases, but proper support would be awesome!

from metadata-action.

tillsteinbach avatar tillsteinbach commented on May 31, 2024

Just tested it with a dev release (this was not working with semver) and a regular release and it works like a charm! Awesome thanks!

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@tillsteinbach Great to hear! Is your repository public so I can take a look at your workflow?

from metadata-action.

tillsteinbach avatar tillsteinbach commented on May 31, 2024

@crazy-max sure: https://github.com/tillsteinbach/WeConnect-mqtt/blob/9bb8d018475d1628289656ac02fb94ef8d3e7940/.github/workflows/python-docker-publish.yml#L72
if you wonder about the "type=raw,value=edge", it is to have the dev versions included in the edge tag (I don't push to docker hub on every commit)

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@tillsteinbach This run has been triggered by a push tag event which is v0.11.2dev3. The metadata action then generates 0.11.2.dev3 and edge which lgtm too:

Run crazy-max/docker-metadata-action@pep440
Context info
  eventName: push
  sha: 0a76359deb20e62645bf1e482f9868ff51c7991b
  ref: refs/tags/v0.11.2dev3
  workflow: Upload Python Package and Docker Image
  action: meta
  actor: ***
  runNumber: 46
  runId: 1004414204
Processing tags input
  type=pep440,pattern={{version}},value=,enable=true,priority=900
  type=raw,value=edge,enable=true,priority=200
Processing flavor input
  latest=auto
  prefix=
  prefixLatest=false
  suffix=
  suffixLatest=false
Docker image version
  0.11.2.dev3
Docker tags
  ***/weconnect-mqtt:0.11.2.dev3
  ***/weconnect-mqtt:edge
  ghcr.io/***/weconnect-mqtt:0.11.2.dev3
  ghcr.io/***/weconnect-mqtt:edge
Docker labels
  org.opencontainers.image.title=WeConnect-mqtt
  org.opencontainers.image.description=MQTT Client that publishes data from Volkswagen WeConnect
  org.opencontainers.image.url=https://github.com/***/WeConnect-mqtt
  org.opencontainers.image.source=https://github.com/***/WeConnect-mqtt
  org.opencontainers.image.version=0.11.2.dev3
  org.opencontainers.image.created=2021-07-06T12:40:39.999Z
  org.opencontainers.image.revision=0a76359deb20e62645bf1e482f9868ff51c7991b
  org.opencontainers.image.licenses=MIT

Also as you can see 0.11.2.dev3 != v0.11.2dev3 because the output is cleaned up to conform with the PEP 440 spec. If you want to preserve the initial Git tag you can use {{raw}} instead.

from metadata-action.

gdubicki avatar gdubicki commented on May 31, 2024

Hey @crazy-max , thanks for your work on this! I'll check it out within a few days.

from metadata-action.

gdubicki avatar gdubicki commented on May 31, 2024

Unfortunately I cannot make it work, @crazy-max .

Probably I am just using GitHub Actions terribly wrong but I am getting:

Error: Unknown type attribute: pep440

I tried referring specifically to the latest as of now v3.4.1 in gitlabform/gitlabform@6418192 but this failed with:

Unable to resolve action `crazy-max/[email protected]`, unable to find version `v3.4.1`

Any suggestions?

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@gdubicki

crazy-max/[email protected]

This is my fork, use docker/metadata-action@v3 instead.

from metadata-action.

gdubicki avatar gdubicki commented on May 31, 2024

🤦‍♂️
Thanks @crazy-max , it helped!

from metadata-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.