Giter Club home page Giter Club logo

Comments (8)

crazy-max avatar crazy-max commented on May 30, 2024

@felipecrs https://github.com/crazy-max/ghaction-docker-meta#latest-tag

from metadata-action.

felipecrs avatar felipecrs commented on May 30, 2024

Got it. The docs says the tag-latest can be disabled if needed, but not deliberately enabled. Is that right?

Any tip on how I can achieve the same behavior as the Docker Hub Automated Build, pushing master branch to latest?

from metadata-action.

felipecrs avatar felipecrs commented on May 30, 2024

I believe the tag-latest input should be respected if provided by the user no matter what. To implement that, its default value must not be true anymore, then we treat the undefined cases.

This is very similar to an old PR I made to the legacy docker action: docker/github-actions#20

from metadata-action.

crazy-max avatar crazy-max commented on May 30, 2024

@felipecrs I think you could specify a custom tag as latest in this case with tag-custom input. Or maybe we could handle 3 states for tag-latest: auto|true|false.

from metadata-action.

felipecrs avatar felipecrs commented on May 30, 2024

@crazy-max Awesome. May I send a PR?

from metadata-action.

beevelop avatar beevelop commented on May 30, 2024

I experienced the same issue and am actually trying to build the master branch as latest. If you have a dedicated repository for the Docker builds, you can work around this limitation by renaming the master branch to latest 🎩

from metadata-action.

felipecrs avatar felipecrs commented on May 30, 2024

As an alternative workaround you can do what I did at felipecrs/docker-images@1900c95.

from metadata-action.

stale avatar stale commented on May 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from metadata-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.