Giter Club home page Giter Club logo

Comments (7)

vitalyster avatar vitalyster commented on May 31, 2024 1

Thank you! Now everything works as expected

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@vitalyster

tag each commit to default branch as 'latest'

Not really a good practice. latest tag should always point to a semver release. But if you really want this you can use:

      - name: Docker meta
        id: docker_meta
        uses: crazy-max/ghaction-docker-meta@v1
        with:
          images: name/app
          tag-semver: |
            {{version}}
          tag-latest: ${{ endsWith(github.ref, github.repository.default_branch) || startsWith(github.ref, 'refs/tags/') }}

from metadata-action.

vitalyster avatar vitalyster commented on May 31, 2024

I pushed these changes to my test repo and behavior still wrong: only master tag is updated correctly, latest tag still broken

from metadata-action.

vitalyster avatar vitalyster commented on May 31, 2024

And I'm OK if latest will point to latest semver release, but now it pointing nowhere

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@vitalyster

latest tag still broken

Yes same issue as #41. tag-latest is only handled on tag-semver or tag-match.

from metadata-action.

vitalyster avatar vitalyster commented on May 31, 2024

It is not the same issue, you are discussing about cases when latest tag is not updated, in my case it is updated with some wrong ref(?), please check

from metadata-action.

crazy-max avatar crazy-max commented on May 31, 2024

@vitalyster

From what I see vitalyster/hello:latest has not been pushed through docker-build-push-action@v2 action but rather manually from your computer or somewhere else as it does not contains a manifest list media-type:

$ docker buildx imagetools inspect vitalyster/hello:latest
Name:      docker.io/vitalyster/hello:latest
MediaType: application/vnd.oci.image.index.v1+json
Digest:    sha256:b1c26f9a9d0b782efe32db37eec98316e300e2e879bc9be558f1d226b418ea97

Manifests:
  Name:      docker.io/vitalyster/hello:latest@sha256:30d5333d20a68dd6ea3689e2c5692d7071f2d68e72c06f0b3b4c7e213df454e2
  MediaType: application/vnd.oci.image.layer.v1.tar+gzip

  Name:      docker.io/vitalyster/hello:latest@sha256:596ba82af5aaa3e2fd9d6f955b8b94f0744a2b60710e3c243ba3e4a467f051d1
  MediaType: application/vnd.oci.image.layer.v1.tar+gzip

  Name:      docker.io/vitalyster/hello:latest@sha256:ccd3b904f96b07b58b445111969725befabf7bb670d7bb9a8f0d997ee7c8fab5
  MediaType: application/vnd.oci.image.layer.v1.tar+gzip

  Name:      docker.io/vitalyster/hello:latest@sha256:ccd3b904f96b07b58b445111969725befabf7bb670d7bb9a8f0d997ee7c8fab5
  MediaType: application/vnd.oci.image.layer.v1.tar+gzip

  Name:      docker.io/vitalyster/hello:latest@sha256:6f635f9114444e8eeb6dbc877c0312e09da686da7d9f150d2f38a080776d60ae
  MediaType: application/vnd.buildkit.cacheconfig.v0

But after looking again I see this manifest only contains cache metadata and from what I see from your workflow is not configured properly. cache-to should be replaced with cache-to: type=inline. See https://github.com/docker/build-push-action/#cache-to-registry as an example.

from metadata-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.