PS: It's not the case if no compose-file is used. How to reproduce<

By default, `parameters.yml` contains `{}` if a compose file is used about app HOT 5 CLOSED

docker commented on May 27, 2024

By default, `parameters.yml` contains `{}` if a compose file is used

from app.

Comments (5)

mnottale commented on May 27, 2024

That's valid yaml for an empty dictionary :)

from app.

Dimrok commented on May 27, 2024

Indeed, but it's just inconsistent.

Shouldn't we always favor the <name>:<carriage return><carriage return> or empty file for empty dictionaries?

from app.

garethr commented on May 27, 2024

Not sure about consistent, but it's aesthetically more pleasing to provide a blank file than the {}.

from app.

ijc commented on May 27, 2024

This seems to still be the case. There's an unspoken assumption that cp.yml contains a valid compose file with nothing which can be detected as a setting.

$ git rev-parse HEAD
3603491fdcc72ebf31195a5ba092e50628dbff38
$ make bin/docker-app
CGO_ENABLED=0 go build -tags="" -ldflags="-s -w -X github.com/docker/app/internal.GitCommit=3603491f -X github.com/docker/app/internal.Version=v0.6.0-44-g3603491f -X github.com/docker/app/internal.Experimental=off -X github.com/docker/app/internal.BuildTime=2019-01-21T11:28:40Z" -o bin/docker-app ./cmd/docker-app
$ cat > cp.yml <<EOF
version: '3.2'
services:
  web:
    build: .
    ports:
     - "5000:5000"
  redis:
    image: "redis:alpine"

EOF
$ ./bin/docker-app init -c cp.yml foo
$ find foo.dockerapp/
foo.dockerapp/
foo.dockerapp/metadata.yml
foo.dockerapp/docker-compose.yml
foo.dockerapp/parameters.yml
$ cat foo.dockerapp/parameters.yml 
{}