Apache does not include conf-enabled, sites-enabled about php HOT 10 CLOSED

I just ran into this issue as well. I copied a default-ssl.conf file into sites-enabled for an image that uses this one as it's base. Was wondering for a while why I was getting SSL handshake errors when trying to access the site.

from php.

Why aren't we using /usr/sbin/apache2ctl to start apache rather than /usr/sbin/apache2? The former sets up environment variables and creates log directories that are missing and a whole slew of things that Apache may need.

from php.

creates log directories that are missing and a whole slew of things that Apache may need.

Setting up the log directories isn't needed; logs are sent to STDOUT (see apache2.conf#L51) so that they are handled by the docker daemon

from php.

conf-enabled contains some vhost-log-configuration which should be disabled for this reason (see my original post). It is also referenced by the included default vhost configuration, so this is to be removed, too.

from php.

@JensErat, you are correct. We should fix the image to have those includes (and wipe out the contents of those directories). Care to make a PR 🙏?

from php.

The patch removes the symlinks for the enabled configuration, but leaves the original files in place (similar how we keep the original Apache configuration as apache2.conf.dist). There are incompatibilities in them, but also in the dist configuration, who ever enables them should know what he's doing anyway. But most of the file's contents is commented out anyway.

The alternative would be to also wipe out the disabled configuration, but I don't see this would do any harm.

Sorry for the two force pushes polluting the issue report, I failed at adding the latest change in the --amend commit before pushing it...

from php.

@JensErat: could you please make a PR with your change 🙏?

from php.

Sure, see #78.

from php.

Thanks a lot @JensErat. @yosifkit, the PR is there :)

from php.

Close this issue @JensErat ?

from php.