Giter Club home page Giter Club logo

Comments (6)

Thr3d avatar Thr3d commented on May 28, 2024

Don't know if it is possible but selecting the version from the same module as the package is installed from seems like the preferable option.

from scc-tools.

frispete avatar frispete commented on May 28, 2024

The version comparison class will select 2.3.5-bp153.1.13 over 2.3.5-1.21. Still considering what to do in this case.

Hm:

$ LANG=C zyp vcmp 2.3.5-bp153.1.13 2.3.5-1.21
Verbosity: 2
Non-option program arguments: '2.3.5-bp153.1.13' '2.3.5-1.21' 
2.3.5-bp153.1.13 is older than 2.3.5-1.21

from scc-tools.

doccaz avatar doccaz commented on May 28, 2024

Don't know if it is possible but selecting the version from the same module as the package is installed from seems like the preferable option.

Good suggestion! I'm at the point where I managed to sort the duplicates by repository, so I guess I just need to take the entry that matches the base product.

from scc-tools.

doccaz avatar doccaz commented on May 28, 2024

The version comparison class will select 2.3.5-bp153.1.13 over 2.3.5-1.21. Still considering what to do in this case.

Hm:

$ LANG=C zyp vcmp 2.3.5-bp153.1.13 2.3.5-1.21
Verbosity: 2
Non-option program arguments: '2.3.5-bp153.1.13' '2.3.5-1.21' 
2.3.5-bp153.1.13 is older than 2.3.5-1.21

Now that is a zypper command I did not know of 😃
I took a look at how zypper is evaluating the versions and releases, and I think my sort function is now able to do similar. Thanks for the tip!

from scc-tools.

frispete avatar frispete commented on May 28, 2024

Yeah, I know, rpm version comparison is pretty tricky in the details - been there, done that before...

It's really funny, that even experienced packagers often don't know the difference of using + versus ~ in revision extensions.

from scc-tools.

doccaz avatar doccaz commented on May 28, 2024

I think I got it now.
It's now dealing with better version sorting: it correctly determined what was older/newer, at least on anything I could throw at it, version and release-wise.
It now gives preference to the package results that come from the corresponding Base channel for the product. If it's there and the version already matches the latest one, there's no need to report the other versions. I tested it against my dozen or so supportconfigs with a mix of different versions/products/architectures, and everything appears to match okay now.

I also noticed that I was "wasting time" looking for packages that were clearly unsupported (different vendor). The logic was corrected.

And lastly, there was an issue with escaping package names that I didn't notice before. I'm now sure "libstdc++6" shouldn't have been reported as unknown that often 😂

from scc-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.