Giter Club home page Giter Club logo

Comments (12)

orodeh avatar orodeh commented on August 10, 2024 1

Should be an easy fix.

from dxda.

orodeh avatar orodeh commented on August 10, 2024 1

Please check it out, new code is part of the new dxWDL release https://github.com/dnanexus/dxWDL/releases/tag/v1.47

from dxda.

dpark01 avatar dpark01 commented on August 10, 2024

Sorry, this looks like maybe this was already addressed in #12 and #22 ? Should I be reporting this issue on dxWDL instead (since it looks like it uses a dxda that predates #12)?

from dxda.

orodeh avatar orodeh commented on August 10, 2024

dxWDL uses the latest dxda on master branch. This looks like a new variation of an old problem. We'll need to investigate.

Does this happen towards the end of the download phase?

from dxda.

dpark01 avatar dpark01 commented on August 10, 2024

Thanks @orodeh -- you can see the context from the job I linked above. It's always after downloads complete. Pasted here:

Obtained token using environment
number of machine cores: 8
memory size: 15 GiB
Downloading files using 16 threads
maximal memory chunk size: 64 MiB
Creating manifest database /home/dnanexus/meta/dxdaManifest.json.bz2.stats.db
Preparing files for download
Required disk space = 3.0GB, available = 181.1GB
Downloaded 3097/3097 MB	44/44 Parts (~51.6 MB/s written to disk estimated over the last 60s)
Download completed successfully.
To perform additional post-download integrity checks, please use the 'inspect' subcommand.
panic: sql: database is closed
goroutine 56 [running]:
github.com/dnanexus/dxda.check(...)
	/go/src/github.com/dnanexus/dxda/util.go:147
github.com/dnanexus/dxda.(*State).queryDBIntegerResult(0xc0000e4120, 0x8e0499, 0x46, 0x0)
	/go/src/github.com/dnanexus/dxda/dxda.go:216 +0x221
github.com/dnanexus/dxda.(*State).DownloadProgressOneTime(0xc0000e4120, 0x37e1324ee, 0xdf72e0, 0x0)
	/go/src/github.com/dnanexus/dxda/dxda.go:514 +0xed
github.com/dnanexus/dxda.(*State).downloadProgressContinuous(0xc0000e4120)
	/go/src/github.com/dnanexus/dxda/dxda.go:546 +0x125
created by github.com/dnanexus/dxda.(*State).DownloadManifestDB
	/go/src/github.com/dnanexus/dxda/dxda.go:794 +0x7e3
download agent failed rc=2
The download log is:

from dxda.

orodeh avatar orodeh commented on August 10, 2024

Oh, I think I know what the problem is. The thread that periodically reports on download progress has not been shut down, and it continues to query the database after it has already been closed.

from dxda.

orodeh avatar orodeh commented on August 10, 2024

Fixed on master.

from dxda.

dpark01 avatar dpark01 commented on August 10, 2024

Hm... I still get this in dxWDL 1.47:

Analysis: https://platform.dnanexus.com/projects/F8PQ6380xf5bK0Qk0YPjB17P/monitor/analysis/Fpyz1B80xf5qY28X2X8YY3z4
Job: https://platform.dnanexus.com/projects/F8PQ6380xf5bK0Qk0YPjB17P/monitor/job/Fpyz26j0xf5j2vPq0p54fjkJ

Obtained token using environment
number of machine cores: 8
memory size: 62 GiB
Downloading files using 16 threads
maximal memory chunk size: 64 MiB
Creating manifest database /home/dnanexus/meta/dxdaManifest.json.bz2.stats.db
Preparing files for download
Required disk space = 34.9GB, available = 274.3GB
Downloaded 6619/35719 MB	140/479 Parts (~0.0 MB/s written to disk estimated over the last 15s)
Downloaded 15619/35719 MB	210/479 Parts (~300.6 MB/s written to disk estimated over the last 51s)
Downloaded 17119/35719 MB	270/479 Parts (~124.3 MB/s written to disk estimated over the last 66s)
Downloaded 25369/35719 MB	340/479 Parts (~240.7 MB/s written to disk estimated over the last 105s)
Downloaded 35719/35719 MB	479/479 Parts (~181.3 MB/s written to disk estimated over the last 60s)
Download completed successfully.
To perform additional post-download integrity checks, please use the 'inspect' subcommand.
panic: sql: database is closed
goroutine 59 [running]:
github.com/dnanexus/dxda.check(...)
	/go/src/github.com/dnanexus/dxda/util.go:149
github.com/dnanexus/dxda.(*State).queryDBIntegerResult(0xc0000d2100, 0xc0000fe000, 0x64, 0x0)
	/go/src/github.com/dnanexus/dxda/dxda.go:212 +0x221
github.com/dnanexus/dxda.(*State).calcBandwidth(0xc0000d2100, 0x1bf08eb000, 0x46)
	/go/src/github.com/dnanexus/dxda/dxda.go:482 +0x10d
github.com/dnanexus/dxda.(*State).DownloadProgressOneTime(0xc0000d2100, 0x1bf08eb000, 0xdada40, 0xbfa79a5ca634cc77)
	/go/src/github.com/dnanexus/dxda/dxda.go:513 +0x136
github.com/dnanexus/dxda.(*State).downloadProgressContinuous(0xc0000d2100, 0xc0005f23f0)
	/go/src/github.com/dnanexus/dxda/dxda.go:570 +0x1ff
created by github.com/dnanexus/dxda.(*State).DownloadManifestDB
	/go/src/github.com/dnanexus/dxda/dxda.go:884 +0x8a4
download agent failed rc=2
The download log is:
2020/05/15 01:33:46 Logging detailed output to: /home/dnanexus/meta/dxdaManifest.json.bz2.download.log
2020/05/15 01:33:46 Obtained token using environment
2020/05/15 01:33:46 Preparing files for download
2020/05/15 01:33:46 Required disk space = 34.9GB, available = 274.3GB
2020/05/15 01:35:59 Downloaded 35719/35719 MB	479/479 Parts (~181.3 MB/s written to disk estimated over the last 60s)
2020/05/15 01:35:59 Download completed successfully.
2020/05/15 01:35:59 To perform additional post-download integrity checks, please use the 'inspect' subcommand.

from dxda.

orodeh avatar orodeh commented on August 10, 2024

This is strange, because the continuous reporting thread has been shut down at this point. I am not sure how it is still operating. This will have to be reopened.

from dxda.

geetduggal avatar geetduggal commented on August 10, 2024

Hi @dpark01 we believe we found the issue and are testing an implementation fix. We will let you know when a dxWDL release will contain this fix. Thanks for reporting.

from dxda.

commandlinegirl avatar commandlinegirl commented on August 10, 2024

Hi @dpark01, we have released dxWDL with the fix. Please let us know if the issue persists or if you encounter any other issues. Thanks!

from dxda.

sclan avatar sclan commented on August 10, 2024

v1.48.1 release fixed both database closed (this issue) and 502 error.
Download it from https://github.com/dnanexus/dxWDL/releases @dpark01

from dxda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.